Account – Infinite loading spinner when closing an account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+shsb22acc1177@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Login with an account
2. Navigate to account settings > Security > Close account
3. Enter the reason and default contact method > Close > Confirm

Expected Result:

User is signed out from the app and the account is closed successfully

Actual Result:

Infinite loading spinner is displayed in the RHP and the user is not logged out from the app

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6609849_1726830617234.2024-09-20_14_01_58.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

i think this could be a backend issue .. as the backend returns an empty response and doesn't properly remove the account, as i still see the old chats after closing the account and login in again

[Shahidullah-Muffakir]

I think this is a regression from PR #48696.

The backend is successfully closing the account, and I even get the confirmation email that the account is deleted. But the problem is that our frontend isn’t receiving the Pusher event. Since the changes in the PR mentioned above affected the Pusher code, I believe that’s what’s causing the issue. I tested it by removing the changes from that PR, and it worked fine.

Pusher is important because it allows the frontend to get real-time updates from the backend. This means the frontend knows right away when something, like account deletion, happens without needing a manual refresh. If the frontend isn’t connected to Pusher properly, it won’t get these updates, which is likely why the account still appears active on the frontend, even though the backend processed the deletion.

[daledah]

I believe #48696 is not the cause of this bug, as the changes in this PR only applies to Expensify Guide member. But I'll take a closer look regardless and will open a follow-up PR as soon as possible if this is actually a regression.

[daledah]

This bug is reproduced in production:

Screen.Recording.2024-09-23.at.22.53.41.mov

[melvin-bot]

@RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MonilBhavsar]

Thanks for confirming @daledah!

[MonilBhavsar]

@jjcoffee were you looking at this bug? Do you mind if I assign you as a C+?

[situchan]

I tested it by removing the changes from that PR, and it worked fine.

If this is true, I would be C+ as regression. Not tested yet though.

[MonilBhavsar]

I agree the PR could not be the reason as we're only subscribing guides to specific channel and since the user experiencing the issue is not a guide.

[MonilBhavsar]

I had a look at the server side code and we're only returning pusher response for CloseAccount API command. I think we should return the API response too for the user taking an action and that should probably fix this issue. Will make a change and see if we still are able to reproduce the issue

[RachCHopkins]

@MonilBhavsar I'll hold off on adding any labels here. Looks like it's potentially Internal?

[MonilBhavsar]

Yes, this is internal issue

[MonilBhavsar]

Got PR in review!

[RachCHopkins]

Are there any steps left here @MonilBhavsar?

[MonilBhavsar]

Thanks for the comment. No, this is fixed! We can close this as it was all internal