Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-20] [A/B Testing][Combined Track Submit] Define logic for displaying test to half of users #49591

Closed
grgia opened this issue Sep 23, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Sep 23, 2024

Show combinedTrackSubmit to 1/2 of all users

So we would take this off beta, and write the logic such that when either global create or the create menu from a chat (or room) is clicked - all even numbered account IDs always see Create Expense and all odd numbered see Track and Submit per usual. We don’t need any of the NVPs as I can just use funnels in Full story.

https://expensify.slack.com/archives/C07HPDRELLD/p1726854156845179?thread_ts=1726506289.927939&cid=C07HPDRELLD

@grgia grgia added the Daily KSv2 label Sep 23, 2024
@grgia grgia self-assigned this Sep 23, 2024
@grgia
Copy link
Contributor Author

grgia commented Sep 23, 2024

https://github.com/Expensify/App/blob/main/src/libs/Permissions.ts#L48-L52

Thinking we just remove the beta and then add the even/odd logic here instead- we could even create a new Permissions file for handling all the logic for future A/B tests.

@anmurali
Copy link

we could even create a new Permissions file for handling all the logic for future A/B tests.

Can you discuss your proposed solution in #engineering-chat tomorrow and make sure we're not missing anything? Then we can move forward with this. I just don't know enough to spot if there's any concerns with this route.

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2024
@grgia
Copy link
Contributor Author

grgia commented Sep 26, 2024

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 26, 2024
@grgia
Copy link
Contributor Author

grgia commented Oct 1, 2024

I can open a PR for this this week

@melvin-bot melvin-bot bot removed the Overdue label Oct 1, 2024
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Oct 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
@grgia
Copy link
Contributor Author

grgia commented Oct 4, 2024

PR in review

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@grgia grgia added the Reviewing Has a PR in review label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

@grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Oct 15, 2024

@grgia Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Oct 17, 2024

@grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Oct 21, 2024

@grgia 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

This issue has not been updated in over 14 days. @grgia eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 13, 2024
@melvin-bot melvin-bot bot changed the title [A/B Testing][Combined Track Submit] Define logic for displaying test to half of users [HOLD for payment 2024-11-20] [A/B Testing][Combined Track Submit] Define logic for displaying test to half of users Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-20. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 19, 2024
@grgia
Copy link
Contributor Author

grgia commented Nov 19, 2024

All internal, closing out as complete

@grgia grgia closed this as completed Nov 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants