[HOLD for payment 2024-10-14] [Search v2.4] Update from, to, in, cardID, taxRate filters to accept names in addition to IDs

[luacmartins]

Problem

Coming from here, we need to update the Search AST algorithm to accept more than just IDs for the from, to, in, cardID and taxRate filters given that Onyx might not have this values locally to replace the names with the appropriate IDs.

Solution

Update the server algorithm that parses the Search AST to handle names in addition to IDs

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Got a couple of draft PRs up. Gonna continue work tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Handle % sign in search #50026

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

No need for regression tests here as stated before in #46031 (comment):

This feature is still WIP, so we'll add them as part of the project wrap up.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ikevin127 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ikevin127]

cc @JmillsExpensify for payment

[melvin-bot]

@JmillsExpensify, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Payment summary: $250 to @ikevin127 for PR testing and review.

[JmillsExpensify]

All paid out and not regression test. Closing this out!