[HOLD for payment 2024-10-10] [$250] [Search v2.1] Web - Search - App returns to Inbox after closing receipt view in Search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense with receipt
4. Go to Search
5. Click on the expense submitted in Step 3
6. Click on the receipt
7. Click X button

Expected Result:

App will return to search page with transaction thread RHP open

Actual Result:

App returns to transaction thread in Inbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6617905_1727473443637.20240928_054138.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840734855215732913
• Upwork Job ID: 1840734855215732913
• Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

bandicam.2024-09-28.00-26-21-579.mp4

[lanitochka17]

We think that this bug might be related to #wave-control

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

	onModalClose={() => {
	Navigation.dismissModal(report?.reportID ?? '-1');
	}}

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

  Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID ?? '-1'));

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

	onModalClose={() => {
	Navigation.dismissModal(report?.reportID ?? '-1');
	}}

What alternative solutions did you explore? (Optional)

[rijusougata13]

Contributor details
Your Expensify account email: rijusougata13@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014959001a9ba2085d

[melvin-bot]

📣 @rijusougata13! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sumairq]

Edited by proposal-police: This proposal was edited at 2024-09-28 23:05:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here whereas we just need to close the open reciept and use a general purpose function .

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

	onModalClose={() => {
	Navigation.dismissModal(report?.reportID ?? '-1');
	}}

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

 onModalClose={() => { 
     Navigation.goBack(); 
 }} 

Video

Screencast.from.2024-09-29.04-19-43.mp4

What alternative solutions did you explore? (Optional)

[github-actions]

thouwhaleu Your proposal will be dismissed because you did not follow the proposal template.

[Kicu]

hey, I work for an expert agency and I would like to work on this issue. I have a lot of context since I worked on search a lot.

[Kicu]

@luacmartins you can assign me, I have a bit of time while waiting on other open Search PRs to merge

[luacmartins]

Thanks @Kicu! Demoting to NAB as well since this bug doesn't really break any functionality

[Kicu]

PR ready #49915. I have not used any of the proposed suggestions, simply using goBack() might've broken some existing cases.

[rayane-djouah]

PR on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix closing TransactionReceipt modal when opened from Search RHP view #49915

If no regressions arise, payment will be issued on 2024-10-10. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Fix - Key Navigation - Pressing CTRL+K in attachment and closing search, leads to different chat #49750
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49750/files#r1789280972
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to workspace chat.
2. Submit an expense with a receipt.
3. Navigate to the Search page.
4. Click on the submitted expense.
5. Click on the receipt within the transaction.
6. Click on the "X" close button to close the receipt view.
7. Verify that the app returns to the search page with the transaction thread in the right-hand panel (RHP) open.

Do we agree 👍 or 👎

[rayane-djouah]

@luacmartins could you please add the Bug label? Thanks!

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1840734855215732913/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[zanyrenney]

bump @rayane-djouah can you apply to the job please? https://www.upwork.com/jobs/~021840734855215732913

[rayane-djouah]

@zanyrenney - Applied https://www.upwork.com/nx/proposals/1845826586166595585

[zanyrenney]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment - ✅
• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK) paid $250 via upwork ✅