Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-22] [3rd Party Feeds] Delete workspace with card feed #49938

Closed
joekaufmanexpensify opened this issue Sep 30, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Sep 30, 2024

Coming from here, we need to implement the deleting workspace with card feed section of the third party workspace feeds v1 doc.

The FE of deleting a workspace already exists. We just need to add the logic related to removing any assigned workspace feeds.

Issue OwnerCurrent Issue Owner: @JmillsExpensify / @abekkala
@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 NewFeature Something to build that is a new item. labels Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 30, 2024
@joekaufmanexpensify
Copy link
Contributor Author

@waterim is taking this. Mind commenting here so we can assign you?

@joekaufmanexpensify joekaufmanexpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #expense Sep 30, 2024
@waterim
Copy link
Contributor

waterim commented Sep 30, 2024

Hello, Im Artem from Callstack and would like to help with this issue

Copy link

melvin-bot bot commented Oct 5, 2024

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@abekkala
Copy link
Contributor

assigning @ishpaul777 as you are reviewing the PR

@abekkala abekkala removed their assignment Oct 11, 2024
@abekkala abekkala added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 11, 2024
@abekkala
Copy link
Contributor

abekkala commented Oct 11, 2024

@JmillsExpensify I'll be ooo until Mon Oct 21
Given that the PR has not deployed to prod starting the 7 day waiting period yet I don't expect this to come to payment before I return from ooo on Oct 21.

STATUS: PR created, but not yet deployed to production

Payment Summary [date, TBD]:

@abekkala abekkala self-assigned this Oct 11, 2024
@abekkala abekkala removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 11, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 15, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 15, 2024
@melvin-bot melvin-bot bot changed the title [3rd Party Feeds] Delete workspace with card feed [HOLD for payment 2024-10-22] [3rd Party Feeds] Delete workspace with card feed Oct 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @waterim does not require payment (Contractor)
  • @ishpaul777 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Oct 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@JmillsExpensify / @abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@dylanexpensify dylanexpensify moved this from Release 2: Summer 2024 (Aug) to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Oct 18, 2024
@dylanexpensify dylanexpensify moved this from Release 3: Fall 2024 (Nov) to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@abekkala
Copy link
Contributor

I'm back from ooo - unassigning @JmillsExpensify

@abekkala
Copy link
Contributor

abekkala commented Oct 21, 2024

Payment Summary for OCT 22

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 21, 2024
@abekkala
Copy link
Contributor

[@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Copy link

melvin-bot bot commented Oct 22, 2024

Payment Summary

Upwork Job

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@abekkala
Copy link
Contributor

waiting on regression test proposal before issuing payment.

@joekaufmanexpensify
Copy link
Contributor Author

@abekkala we can skip the regression test here. I wrote tests for the entire feature, which include this case. We'll pass all the tests off to applause as new regression tests once we finish our pre-launch testing.

@abekkala
Copy link
Contributor

@ishpaul777 payment sent and contract ended - thank you! 🎉

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

6 participants