-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-22] [3rd Party Feeds] Delete workspace with card feed #49938
Comments
Triggered auto assignment to @abekkala ( |
@waterim is taking this. Mind commenting here so we can assign you? |
Hello, Im Artem from Callstack and would like to help with this issue |
Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
assigning @ishpaul777 as you are reviewing the PR |
Triggered auto assignment to @JmillsExpensify ( |
@JmillsExpensify I'll be ooo until Mon Oct 21 STATUS: PR created, but not yet deployed to productionPayment Summary [date, TBD]:
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I'm back from ooo - unassigning @JmillsExpensify |
Payment Summary for OCT 22
|
[@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases. |
Payment Summary
BugZero Checklist (@abekkala)
|
waiting on regression test proposal before issuing payment. |
@abekkala we can skip the regression test here. I wrote tests for the entire feature, which include this case. We'll pass all the tests off to applause as new regression tests once we finish our pre-launch testing. |
@ishpaul777 payment sent and contract ended - thank you! 🎉 |
Coming from here, we need to implement the deleting workspace with card feed section of the third party workspace feeds v1 doc.
The FE of deleting a workspace already exists. We just need to add the logic related to removing any assigned workspace feeds.
Issue Owner
Current Issue Owner: @JmillsExpensify / @abekkalaThe text was updated successfully, but these errors were encountered: