Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] LHN - $0.00 is displayed when deleting an expense #50081

Closed
2 of 6 tasks
lanitochka17 opened this issue Oct 2, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): biruknew45+1317@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. As an admin, create a workspace and add an employee as a member
  3. Enable the following settings as an admin:
  • Workflow: enabled
  • Approval: enabled
  • Delay submission: set to manual
  1. As the employee, go to the workspace chat and submit an expense
  2. Click on the "Submit" button
  3. Click on "Preview," navigate to the header, and delete the expense

Expected Result:

The expense should be deleted successfully, and the amount $0.00 should not be displayed in the LHN

Actual Result:

In the LHN, "[admin] owes $0.00" is displayed after the expense is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622228_1727882129576.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor

@jasperhuangg
Copy link
Contributor

Asked QA for retest here

@jasperhuangg
Copy link
Contributor

This was validated to be fixed via this

@jasperhuangg jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Oct 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2024
@melvin-bot melvin-bot bot changed the title LHN - $0.00 is displayed when deleting an expense [HOLD for payment 2024-10-10] LHN - $0.00 is displayed when deleting an expense Oct 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-10. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-10] LHN - $0.00 is displayed when deleting an expense [HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] LHN - $0.00 is displayed when deleting an expense Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-11. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2024
@situchan
Copy link
Contributor

Please assign me here

Copy link

melvin-bot bot commented Oct 14, 2024

@Beamanator Eep! 4 days overdue now. Issues have feelings too...

@Beamanator Beamanator added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Beamanator
Copy link
Contributor

@twisterdotcom this was a blocker which was fixed in #50110 by @situchan - it's been in prod long enough that payment is due 🙏

@twisterdotcom
Copy link
Contributor

I assume $250 right? If so: Payment Summary:

@situchan
Copy link
Contributor

@twisterdotcom I am not paid yet

@twisterdotcom
Copy link
Contributor

Thanks for noting. Got it paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants