[HOLD for payment 2024-11-11] [$250] Automate author checklist with ESLint rules

[szymonrybczak]

Problem:

The current Author Checklist for creating a Pull Request contains 48 checks, which is an excessive number of items to be manually verified every time a PR is submitted. This lengthy process can slow down the development workflow.

Solution

Automate checks with ESLint rules where possible, as we've found some checklist items that can be easily automated.

• I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.

  Here’s a diff presenting a potential implementation: callstack-internal/eslint-config-expensify@b31ad44.

  After applying diff locally there’s only one error in whole codebase:

  ❯ npm run lint
  
  > new.expensify@9.0.37-0 lint
  > NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/eslint
  
  This is not a desktop build, adding babel-plugin-annotate-react
  babel.config.js
    - api.version: 7.24.5
    - api.env: development
    - process.env.NODE_ENV: undefined
    - process.env.BABEL_ENV: undefined
    - running in:  undefined
  
  ~/Users/szymonrybczak/callstack/App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx
    102:30  error  The left side of conditional rendering should be a boolean, not Unit  rulesdir/boolean-conditional-rendering
  
  ✖ 1 problem (1 error, 0 warnings)
  

  The lint rule examines the left-side condition of an expression. If it detects a non-boolean value, it raises an error — once this rule is implemented, we can remove the corresponding check from the Author Checklist in the Pull Request template.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849137380340533101
• Upwork Job ID: 1849137380340533101
• Last Price Increase: 2024-10-23

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

@rayane-djouah for implementation, what is your eta for the pr, soˇe diff is already available

[rayane-djouah]

I'm starting right now

[rayane-djouah]

I've encountered issues with the isBoolean function and its implementation in the OP's code diff. Additionally, I've noticed problems with the formatting of error messages.
Also, I have added tests for this rule.

Here's the draft PR: Expensify/eslint-config-expensify#121. Note: I am still investigating a lint error.

[rayane-djouah]

Fixed the Lint errors 🎉

[rayane-djouah]

@szymonrybczak @mountiny PR ready for review

[mountiny]

@szymonrybczak is going to review the eslint PR

[mountiny]

@rayane-djouah merged, can you please make App PR now 🙏

[rayane-djouah]

I'm waiting on #50935 to be merged

[mountiny]

Merged

[sakluger]

@mountiny it looks like this one is pretty much complete! How should we handle payment for this issue? $250 to @rayane-djouah in 7 days?

[mountiny]

Yes!

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849137380340533101

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[sakluger]

Summarizing payment on this issue:

Contributor: @rayane-djouah $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/104560122

[mountiny]

@rayane-djouah we still need to update App right?

[rayane-djouah]

Yes, I'm working on an App PR

[sakluger]

Okay we'll wait to pay out until 7 days after the App PR is deployed.

[rayane-djouah]

@mountiny @szymonrybczak App PR ready for review: #51741

[rayane-djouah]

Merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Bump eslint-config-expensify version (boolean-conditional-rendering rule) #51741

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @szymonrybczak does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

@rayane-djouah @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-djouah]

No BugZero Checklist is required as this is a new feature. Additionally, no regression testing is necessary because this is a tool for developers.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @szymonrybczak is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/104560122)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1849137380340533101/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct