[HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has set up bank account.
• Employee does not have personal bank account.

1. Go to staging.new.expensify.com
2. [Employee] Submit an expense in the workspace chat.
3. [Admin] Pay the expense via Expensify.
4. [Employee] Click on the expense preview.
5. [Employee] Click Add bank account button.

Expected Result:

The report view will persist when Add bank account RHP opens (production behavior).

Actual Result:

The report view changes to Wallet page when Add bank account RHP opens.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6623630_1727985420544.20241004_035429.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report view changes to Wallet page when Add bank account RHP opens.

What is the root cause of that problem?

The add personal bank account screen was mapped to settings profile screen:

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Line 41 in d9882a3

SCREENS.SETTINGS.ADD_BANK_ACCOUNT,

What changes do you think we should make in order to solve the problem?

Add that screen to the RHP_SCREENS_OPENED_FROM_LHN:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 24 in d8cda53

const RHP_SCREENS_OPENED_FROM_LHN = [

[techievivek]

@mkzie2 We require the original author to fix the regression issues and in this case it seems to be originating from this one https://github.com/Expensify/App/pull/49230/files

CC @daledah

[techievivek]

There are already a few blocker linked to that PR so if the author is not online to fix it ASAP we might need to revert the original PR.

[daledah]

@techievivek I accidentally added this change because I thought this one was a bug, as mentioned in #49230 (comment), cc @jjcoffee. I'm opening a followup PR soon. But the screenshots may come up late, as the test requires user to be validated and magic code is not sent to user #50210

[techievivek]

@daledah Magic code arriving late is fixed from backend, you should be receiving them now. Can you please it and confirm?

[daledah]

@techievivek Yes, I received the magic codes. Opening a PR soon!

[techievivek]

Thank you.

[daledah]

@techievivek Here's the PR
Look like this button doesn't have logics added in #49230 yet, do you want me to add changes to this as well? Or we should keep current behavior of showing not found page when user is not validated?

[jjcoffee]

The PR still has an issue if you dismiss the Plaid modal. @techievivek I don't think this needs to be a blocker, as the user can just navigate back to the chat.

[techievivek]

Yeah, agree that it can be demoted.

[techievivek]

Look like this button doesn't have logics added in #49230 yet, do you want me to add changes to this as well? Or we should keep current behavior of showing not found page when user is not validated?

Which button did you mean here?

[daledah]

@techievivek Sorry, I missed your comment. I mean the add bank account button on the report page.

[techievivek]

@daledah Yeah, we do require the validation check for that button as well.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove add bank account page from central pane mapping #50228

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

No payment due here as this was a regression fix.

[melvin-bot]

@techievivek @bfitzexpensify Be sure to fill out the Contact List!

[tgolen]

Reopening so @jjcoffee and @bfitzexpensify can fill out the regression checklist.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: fix: requires validate when opening bank account #49230
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49230/files#r1816173504
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - missed testing buttons in other locations
• Determine if we should create a regression test for this bug. Yes - if one doesn't exist
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Preconditions:

• Workspace has set up bank account.
• Employee does not have personal bank account.

1. [Employee] Submit an expense in the workspace chat.
2. [Admin] Pay the expense via Expensify.
3. [Employee] Click on the expense preview.
4. [Employee] Click Add bank account button.
5. [Employee] Verify that the report view will persist when Add bank account RHP opens

Do we agree 👍 or 👎

[bfitzexpensify]

Looks good to me! Proposed in https://github.com/Expensify/Expensify/issues/438948

[melvin-bot]

@techievivek @bfitzexpensify Be sure to fill out the Contact List!