[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Accounting - Empty row is displayed in accountings page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+shsb22cp111@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Log in to any account
2. Create a new workspace
3. Navigate to more features > Enable Accounting
4. Navigate to accounting page and observe the fifth row

Expected Result:

No empty row is displayed in the page

Actual Result:

An empty row is displayed with a connect button which doesn't navigate to anything when clicked

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6627983_1728364648198.2024-10-08_08_10_53.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-08 09:25:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

An empty row is displayed with a connect button which doesn't navigate to anything when clicked

What is the root cause of that problem?

QBD is included in the connections list here:

App/src/CONST.ts

Line 2304 in 256a747

QBD: 'quickbooksDesktop',

But its integration data has not been defined yet:

App/src/pages/workspace/accounting/utils.tsx

Line 40 in 56ca85f

function getAccountingIntegrationData(

Causing the menu items here to have one empty row:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Line 387 in 0c52433

const integrationData = getAccountingIntegrationData(integration, policyID, translate);

What changes do you think we should make in order to solve the problem?

Early return for undefined integrationData and filter the otherIntegrations to only get truthy values.

We faced this problem several times in the past when a new integration is added. I think we should not ignore it because we will get more and more integrations in the future.

[ZhenjaHorbach]

@hoangzinh @lakchote
This is ours
I think we can fix it in one of our PRs

[hoangzinh]

I think we can spin up a quick PR to remove the deploy blocker.

[hoangzinh]

@ZhenjaHorbach are you available to open a PR? I can help to review

[ZhenjaHorbach]

@ZhenjaHorbach are you available to open a PR? I can help to review

Yes
I will create after 5 minutes

[MonilBhavsar]

This is fixed. Thanks all for the help!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix connectionsMenuItems with undefined items #50386

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix connectionsMenuItems with undefined items #50386

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: