[HOLD for payment 2024-10-30] Add RBR reason to LHN debugging

[puneetlath]

As discussed here, let's add the reason a given report is showing an RBR in the LHN to the reports debug information. Similar to what we do for GBRs.

cc @pac-guerreiro

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[pac-guerreiro]

Hey, yesterday I opened a draft PR for this so you can see my progress while I work on this issue 😄

Here is what remains to be done:

• Add RBR reason test cases in DebugUtilsTest.ts
• Add screenshots
• Add QA testing steps

[pac-guerreiro]

Today's update:

• Add RBR reason test cases in DebugUtilsTest.ts

Todo:

• Fix unit test for when there are transaction thread violations
• Add screenshots
• Add QA testing steps

[puneetlath]

Thanks for these updates!

[pac-guerreiro]

The PR is now ready for review! 😄

Go ahead @DylanDylann

[pac-guerreiro]

I just applied the suggested changes by @puneetlath and @DylanDylann.

The PR is ready for a new review 😄

[pac-guerreiro]

The PR was finally merged 🙌

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add RBR reason to LHN debugging #50831

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @pac-guerreiro is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[DylanDylann]

The regression test is covered here

[melvin-bot]

@puneetlath, @pac-guerreiro, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@puneetlath, @pac-guerreiro, @DylanDylann Still overdue 6 days?! Let's take care of this!

[puneetlath]

@DylanDylann I'm going to have each of the debug mode PRs be a milestone on one Upwork job. Just to make things easier for me to pay.

The offer for is here: https://www.upwork.com/nx/wm/offer/new/1039087488. I've added 3 PRs as milestones so far. I'll add the others as milestones as we go.

Please ping me here when you've accepted.

[DylanDylann]

@puneetlath Accepted 🙏

[puneetlath]

Paid this one. Thanks y'all!