Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-03] [$250] [Per Diem] Frontend - Add default category for Per Diem in Newdot #50871

Closed
Gonals opened this issue Oct 16, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@Gonals
Copy link
Contributor

Gonals commented Oct 16, 2024

Part of the Add Per Diem to New Expensify project

Main issue: https://github.com/Expensify/Expensify/issues/400276
Doc section: https://docs.google.com/document/d/1c6WDOJlhvODD0mRKaCHfQk_HRNmq5K7hSDHLu06Pbq8/edit?tab=t.0#bookmark=id.4kv6q4at5wxd
Project: https://github.com/Expensify/Expensify/issues/400276

Feature Description

Add the necessary changes to add a default category for Per Diem in newdot workspaces

Manual Test Steps

Automated Tests

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846484427769463383
  • Upwork Job ID: 1846484427769463383
  • Last Price Increase: 2024-10-16
  • Automatic offers:
    • shubham1206agra | Reviewer | 105023085
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @shubham1206agra
@Gonals Gonals added External Added to denote the issue can be worked on by a contributor Engineering Weekly KSv2 labels Oct 16, 2024
@melvin-bot melvin-bot bot changed the title [Per Diem] Frontend - Add default category for Per Diem in Newdot [$250] [Per Diem] Frontend - Add default category for Per Diem in Newdot Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021846484427769463383

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2024
@Gonals Gonals added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 16, 2024
@35C4n0r
Copy link

35C4n0r commented Oct 16, 2024

Is this still up for grabs?

Copy link

melvin-bot bot commented Oct 16, 2024

📣 @35C4n0r! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@35C4n0r
Copy link

35C4n0r commented Oct 16, 2024

Contributor details
Your Expensify account email: work.jaykumar@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ea92c79ab8974b5c

Copy link

melvin-bot bot commented Oct 16, 2024

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

@35C4n0r
Copy link

35C4n0r commented Oct 16, 2024

Contributor details
Your Expensify account email: work.jaykumar@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ea92c79ab8974b5c

Copy link

melvin-bot bot commented Oct 16, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@35C4n0r
Copy link

35C4n0r commented Oct 16, 2024

Contributor details
Your Expensify account email: work.jaykumar@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ea92c79ab8974b5c

Copy link

melvin-bot bot commented Oct 16, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Gonals
Copy link
Contributor Author

Gonals commented Oct 17, 2024

@shubham1206agra is assigned to this one 😁

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@Gonals
Copy link
Contributor Author

Gonals commented Oct 31, 2024

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2024
@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review and removed Weekly KSv2 labels Nov 11, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Weekly KSv2 labels Nov 12, 2024
@c3024
Copy link
Contributor

c3024 commented Nov 21, 2024

@Gonals , could you assign me to this issue as I am reviewing the PR?

Copy link

melvin-bot bot commented Nov 22, 2024

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Nov 22, 2024

❌ There was an error making the offer to @c3024 for the Contributor role. The BZ member will need to manually hire the contributor.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Per Diem] Frontend - Add default category for Per Diem in Newdot [HOLD for payment 2024-12-03] [$250] [Per Diem] Frontend - Add default category for Per Diem in Newdot Nov 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@shubham1206agra
Copy link
Contributor

Only @c3024 is required to be paid here. I will be paid at the end of the project.

@c3024
Copy link
Contributor

c3024 commented Dec 3, 2024

This is a new feature and part implementation. This does not need a regression test.

@c3024
Copy link
Contributor

c3024 commented Dec 6, 2024

@twisterdotcom this is ready for payment. Can you please post the payment summary so that I can request in ND?

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2024
@twisterdotcom
Copy link
Contributor

twisterdotcom commented Dec 6, 2024

Ah sorry, I misunderstood here. Payment Summary:

@melvin-bot melvin-bot bot removed the Overdue label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants