mWeb - Search - No offline indicator at the bottom of the page in Search modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Open FAB > Start chat.
4. Note that there is offline indicator below the search input and also at the bottom of the page.
5. Open a report.
6. Tap on the search icon.

Expected Result:

There will be offline indicator at the bottom of the page just like Start chat list in Step 4.

Actual Result:

There is no offline indicator at the bottom of the page in Search modal.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637275_1729145695234.Screen_Recording_20241017_131150_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no offline indicator at the bottom of the page in Search modal.

What is the root cause of that problem?

There are no offline indicators inside SearchRouterModal

What changes do you think we should make in order to solve the problem?

Add OfflineIndicator to after here in SearchRouterModal:

App/src/components/Search/SearchRouter/SearchRouterModal.tsx

Line 23 in cd2c7dd

<FocusTrapForModal active={isSearchRouterDisplayed}>{isSearchRouterDisplayed && <SearchRouter onRouterClose={closeSearchRouter} />}</FocusTrapForModal>

What alternative solutions did you explore? (Optional)

[rayane-djouah]

Based on the design mocks, we did not consider adding an offline indicator in the search router modal.
@Expensify/design, could you confirm whether this is a bug or not?
cc @luacmartins

[shawnborton]

Do we need an indicator at the bottom? It literally says you are offline right below the input:

[rayane-djouah]

Yeah, I don't think this is a bug

[twisterdotcom]

@IuliiaHerets - was this a testrail case? If so, let's get that changed. If not, let's ignore. Setting to weekly. We can close once you've answered.

[dannymcclain]

I agree we don't need an indicator at the bottom since we have one right below the search field. @shawnborton do you think we should add the offline icon there and treat that lock up similar to the one we show at the bottom?

[shawnborton]

I don't feel too strongly. I could see that, but I am also fine leaving this one as-is because it's being treated consistently like other messages we show below the search input:

Happy to defer to you (and Jon) on that one!

[luacmartins]

Sounds good. @IuliiaHerets Let's just confirm if this is a TC and either remove it or close this issue.

[dannymcclain]

Ok cool, let's get @dubielzyk-expensify to weigh in. I don't feel SUPER strongly, but I do think I have some feelings? Maybe? Jon, you must choose:

[IuliiaHerets]

@twisterdotcom @luacmartins It is an exploratory issue, not a TR.

[luacmartins]

Cool, so we can close this.

[dubielzyk-expensify]

I think I prefer the icon there, but I prefer the alignment of the text on the right.