[HOLD for payment 2024-10-29] Search - Contacts with no chat history are also categorized under "Recent chats"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new private domain account (Expensifail).
3. Open FAB > Start chat.
4. Note that the contacts under "Recent chats" are only Concierge and yourself.
5. Open Concierge.
6. Click Search icon.
7. Note that Recent chats include all the contacts instead of just Concierge and yourself.

Expected Result:

In Search modal, "Recent chats" should only include Concierge and self DM, while the other contacts should be under "Contacts" section.

Actual Result:

In Search modal, "Recent chats" includes Concierge, self DM and the rest of the contacts which user has never chatted with before.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637299_1729144214325.20241017_134534.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rayane-djouah]

@luacmartins @Expensify/design I initially thought it was intentional to include all search report options under one section title ("Recent chats"). Do we need to split the options into "Recent searches", "Recent chats", and "Contacts", or should we exclude the contacts options from the list?

[rayane-djouah]

cc @Kicu @SzymczakJ

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Search modal, "Recent chats" includes Concierge, self DM and the rest of the contacts which user has never chatted with before.

What is the root cause of that problem?

In SearchRouter, we merge recent reports and personal details as one:

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 86 to 93 in 987ff1b

	const recentReports: OptionData[] = useMemo(() => {
	const currentSearchOptions = debouncedInputValue === '' ? searchOptions : filteredOptions;
	const reports: OptionData[] = [...currentSearchOptions.recentReports, ...currentSearchOptions.personalDetails];
	if (currentSearchOptions.userToInvite) {
	reports.push(currentSearchOptions.userToInvite);
	}
	return reports.slice(0, 10);
	}, [debouncedInputValue, filteredOptions, searchOptions]);

And in 'SearchRouterList`, we only have "Recent Chats" section, not "Contacts" section:

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 147 in 987ff1b

sections.push({title: translate('search.recentChats'), data: styledRecentReports});

What changes do you think we should make in order to solve the problem?

Add a param personalDetailLists to SearchRouterList and add "Contacts" section:

sections.push({title: translate('common.contacts'), data: personalDetailsList});

Then in here, remove currentSearchOptions.personalDetails from recentReports

Create personalDetailLists memo in 'SearchRouterand pass it toSearchRouterList`:

const personalDetailsList: OptionData[] = useMemo(
        () => (debouncedInputValue === '' ? searchOptions.personalDetails : filteredOptions.personalDetails),
        [debouncedInputValue, searchOptions, filteredOptions],
);

POC

What alternative solutions did you explore? (Optional)

[MariaHCD]

This doesn't need to block the deploy. It can be a follow up improvement as part of the Search project.

[shawnborton]

Hmm I would think we would only show actual recent chats in the recent chats section. No need to show Contacts here IMO.

[dannymcclain]

Hmm I would think we would only show actual recent chats in the recent chats section. No need to show Contacts here IMO.

Same—IMO the options we display in the router are "quick shortcuts". We're surfacing them for convenience. If you're looking for a contact you can use the router to search for it.

[SzymczakJ]

The only place to view your contacts that I knew about was ChatFinderPage. If we're going to remove contacts from SearchRouter how else will we view them? @dannymcclain @shawnborton

[shawnborton]

I don't think anyone is suggesting to remove contacts from the SearchRouter. But the default "suggestions" perhaps should only include Recent chats, if that makes sense.

[SzymczakJ]

I like that solution 😃. So to finally clarify: if user hasn't put anything in the text input then we only show recent chats, but when user typed something we show whatever is closest to the searched phrase(just like ChatFinderPage did)?

[shawnborton]

Yeah, that is my understanding! cc @luacmartins for the gut check there too

[dannymcclain]

Yes that's what I was thinking too!

[luacmartins]

That seems fine to me as well.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Search router polish  #50921

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MariaHCD / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@MariaHCD / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MariaHCD / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@SzymczakJ] Determine if we should create a regression test for this bug.
• [@SzymczakJ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@MariaHCD, @luacmartins, @VictoriaExpensify, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@MariaHCD, @luacmartins, @VictoriaExpensify, @SzymczakJ Still overdue 6 days?! Let's take care of this!

[luacmartins]

Waiting on payment @VictoriaExpensify

[VictoriaExpensify]

I don't think anyone needs to be paid here - @SzymczakJ is a contractor and everyone else is internal. If I've missed someone that needs payment, let me know!

Otherwise, we are just waiting for the checklist to be complete and we can close this out