IOS - Hybrid app - App crashed when logout offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5094453
Email or phone of affected tester (no customers): rybkina+101724b@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch App as login user
2. Go to offline
3. Navigate to setting > Sign Out
4. Tap on Sign Out on popup "Are you sure?"

Expected Result:

User should log out

Actual Result:

App crashed when logout offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6638129_1729195743437.crash.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

Ohsb1243.1.mp4

[marcaaron]

Asked for more information here. Please post device logs whenever creating issues with crashes that are consistently reproducible (and whether it is consistently reproducible).

[kavimuru]

Device logs
Expensify-2024-10-17-173006.txt

[marcaaron]

Based on the logs this looks like some kind of null pointer reference issue similar to what we have here.

It's unclear what the root cause might be to me. Seems related to trying to clear out a view or some kind of data. @Julesssss @AndrewGable might know more.

[marcaaron]

App crashed when logout offline

Also this only happens when offline? If so, not sure if it needs to be a blocker.

[Julesssss]

Agree with both of your points. It seems likely that firebase crash IS this crash, adding a comment in Firebase linking it to this issue would be helpful.

[melvin-bot]

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

Added a comment to firebase.

I think the next step for this issue would be to try and build HybridApp locally then sign out while offline to see if it's reproducible. I have not yet had success in building HybridApp locally will start a thread to get some help there.

[marcaaron]

AFAICT this is what gets called when we sign out:

https://github.com/Expensify/App/blob/bab932cb085523abcf7e6efc5e6d9de2345dd87d/src/libs/actions/Session/index.ts#L211C1-L214C10

Which then calls the native module here:

https://github.com/Expensify/Mobile-Expensify/blob/44f91cc30683a0edd9b7468acbff52e7be8c0c07/iOS/Expensify/HybridAppModule.swift#L13C1-L17C6

Ok, managed to build the app and I cannot reproduce this one locally. Gonna make it a weekly for now and let's give it a re-test after the next deploy.

[mateuuszzzzz]

Hi @marcaaron I'm currently working on this crash. I noticed that after enabling bridgeless mode on HybridApp(iOS only) these crashes stopped appearing in Crashlytics. Bridgeless was introduced in 9.0.54.1 and last crash was on 9.0.53.1

There’s a chance we might not see this issue anymore 😅

[marcaaron]

Nice. Thanks, I'm going to close this out and see if it gets reported again.