Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Allow user to create international bank account #51082

Open
8 tasks
MonilBhavsar opened this issue Oct 18, 2024 · 36 comments
Open
8 tasks

Feature - Allow user to create international bank account #51082

MonilBhavsar opened this issue Oct 18, 2024 · 36 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Oct 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Tracking issue https://github.com/Expensify/Expensify/issues/421064
Implement this section of design doc https://docs.google.com/document/d/19ltca0iKwB00pReokjBf9rEHoi1u8y-2_x-82jMibho/edit?tab=t.0#bookmark=id.183ls0sldt64

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: N/A
Slack conversation: N/A

Action Performed:

Break down in numbered steps
N/A

Expected Result:

Describe what you think should've happened
N/A

Actual Result:

Describe what actually happened
N/A

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lschurr
@MonilBhavsar MonilBhavsar added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@MonilBhavsar
Copy link
Contributor Author

@shawnborton sorry for the ping. This is implementation for design doc and design is already approved by the team

@shawnborton
Copy link
Contributor

No worries, just holler if you need any help!

@lschurr
Copy link
Contributor

lschurr commented Oct 18, 2024

Should we have External added here @MonilBhavsar or is this already assigned and being worked on?

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@lschurr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar MonilBhavsar self-assigned this Oct 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@shubham1206agra
Copy link
Contributor

@MonilBhavsar Can you make this weekly?

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Oct 22, 2024
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2024
@MonilBhavsar
Copy link
Contributor Author

Making this Daily again since nothing is blocking

Copy link

melvin-bot bot commented Nov 1, 2024

@MonilBhavsar, @lschurr, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 4, 2025
@melvin-bot melvin-bot bot changed the title Feature - Allow user to create international bank account [HOLD for payment 2025-01-13] Feature - Allow user to create international bank account Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 6, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Jan 7, 2025
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Payment Summary

Upwork Job

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lschurr
Copy link
Contributor

lschurr commented Jan 13, 2025

Hey @MonilBhavsar @shubham1206agra I see this PR was reverted on Jan 2nd, but is now on prod. Was that a regression? What is the payment amount for this one?

@MonilBhavsar
Copy link
Contributor Author

Yep, the PR was reverted and @shubham1206agra is working on a followup. So payment is not due here yet.
Also, this is an #expense project and shubham is being paid for the entire project and not this issue. So no payment required here as of now.

@melvin-bot melvin-bot bot added the Overdue label Jan 15, 2025
@lschurr
Copy link
Contributor

lschurr commented Jan 15, 2025

Ah, great thanks! Closing this one out.

@lschurr lschurr closed this as completed Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Jan 15, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2025
@shubham1206agra
Copy link
Contributor

@lschurr Please reopen this issue as the underlying issue is not yet completed

@lschurr
Copy link
Contributor

lschurr commented Jan 15, 2025

Ah, sorry about that. Reopening.

@lschurr lschurr reopened this Jan 15, 2025
@lschurr lschurr changed the title [HOLD for payment 2025-01-13] Feature - Allow user to create international bank account Feature - Allow user to create international bank account Jan 15, 2025
@lschurr lschurr removed the Awaiting Payment Auto-added when associated PR is deployed to production label Jan 15, 2025
@lschurr lschurr moved this from Done to Bugs and Follow Up Issues in [#whatsnext] #expense Jan 16, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 20, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

@MonilBhavsar, @lschurr, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

@lschurr
Copy link
Contributor

lschurr commented Jan 22, 2025

Any update here @shubham1206agra? Should this be made Weekly?

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

8 participants