Hybrid iOS - App crashes when tapping app back button on Book travel page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.51-0
Reproducible in staging?: Can't check
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #49602
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch hybrd app.
2. Open Menu.
3. Tap Try New Expensify.
4. Go to Account settings > Switch to Expensify Classic.
5. Open Menu.
6. Tap Trips.
7. Tap app back button.
8. Tap Trips.
9. Tap app back button.
10. If the app does not crash, kill the app and repeat Step 1 to 9.

Expected Result:

App will not crash when tapping app back button on Book travel page.

Actual Result:

App crashes when tapping app back button on Book travel page.
Sometimes it crashes when opening Trips on OD.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2010.txt

Bug6640122_1729412752135.ScreenRecording_10-20-2024_16-20-36_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mateuuszzzzz]

I filtered crashlytics to match information provided by @IuliiaHerets. It seems like we have only two crashes that match this data.

This issue is related to react-native-sql-lite. We've been aware of the problem for quite some time, and @war-in has been working on a fix

[mateuuszzzzz]

I filtered crashlytics to match information provided by @IuliiaHerets. It seems like we have only two crashes that match this data.

This issue is related to react-native-sql-lite. We've been aware of the problem for quite some time, and @war-in has been working on a fix

Perhaps we can create a separate issue. Tapping the app's back button on the Book Travel page is just one scenario where we can witness this crash

[Julesssss]

If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y

Hey @IuliiaHerets, I just wanted to check that this is reproducable on NewDot standalone? And are the steps the same or different? Thanks

[IuliiaHerets]

Cannot check because the steps require a transition from OD to ND, but if just try to tap the back button on the Book Travel page - crash not repro

ScreenRecording_10-22-2024.02-03-44_1.MP4

[AndrewGable]

We just CP-ed two reverts that should fix this #51155, waiting for them to deploy and then I can confirm and close this out

[AndrewGable]

Confirmed this is fixed from the revert!