[HOLD for payment 2024-11-14] Debug mode for Inbox tab GBR doesn't handle multi-policy

[puneetlath]

As discussed here, we need to fix debug mode for RBRs on the Inbox tab to work across policies.

cc @pac-guerreiro

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[pac-guerreiro]

@puneetlath I opened a draft PR - #51425

Today's update:

• Add reportID to optimistic report
• Extract reportID from report key to prevent redirecting the user to reports with undefined IDs
• Add View Report button in debug report page

Todo:

• Prevent report from being re-fetched after deleting it from debug report page
• Add screen recordings
• Add QA steps

[pac-guerreiro]

@puneetlath @DylanDylann

I'm set the PR as ready for review although it's missing QA steps and screen recordings for native app.

I'll add these next Monday!

[pac-guerreiro]

@puneetlath @DylanDylann

I wasn't able to find steps to test this on native platforms yet. Will continue my research tomorrow!

[pac-guerreiro]

@puneetlath today I applied the suggestions from @DylanDylann to the PR. I still don't have steps to test on native platforms, do you have any ideas?

[pac-guerreiro]

@puneetlath today I applied a change that I discussed with @DylanDylann here

[pac-guerreiro]

@puneetlath the PR is ready to be merged 😄

[pac-guerreiro]

@puneetlath the PR is waiting to be merged

[pac-guerreiro]

The PR is merged, thanks @puneetlath 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Debug mode for Inbox tab GBR doesn't handle multi-policy #51425

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @puneetlath The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @pac-guerreiro is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@DylanDylann I added a new milestone for this one here: https://www.upwork.com/nx/wm/workroom/38901941/overview?nav_dir=pop

Do we need to update our regression tests?

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

Only for Web (Laptop), Desktop App

1. Open a report that doesn't exist from the browser URL (e.g. /r/12345)
2. The view above the bottom navigation bar will show up a message saying There's a report with errors
3. Clicking on View button will open the RHP with the debug report page with the data of the report
4. Scroll down and click on the delete button will clear the RBR

Do we agree 👍 or 👎

[puneetlath]

Paid the milestone. Regression test issue here: https://github.com/Expensify/Expensify/issues/444815

Thanks y'all!