[HOLD for payment 2024-12-05] [$250] Update headers in certain flows to match their screens

[jamesdeanexpensify]

Background

Coming from this Slack convo, we'd like to update the header copy in certain product flows to more closely match what's happening in the associated screen.

Which flows to update

• Track expense
• Submit expense
• Create expense
• Split expense
• Pay (user)

Where to find the specific details

https://docs.google.com/document/d/1IAnUtW4JzLApeMDuO1-GPD8Y11vPQl9AsFiTOiWp2bM/edit?tab=t.0

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021860038796835570004
• Upwork Job ID: 1860038796835570004
• Last Price Increase: 2024-11-22
• Automatic offers:
• c3024 | Reviewer | 105201449

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

@jamesdeanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jamesdeanexpensify]

Updates start here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021860038796835570004

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[c3024]

Raised a PR #53004.

🎀 👀 🎀 for internal engineer for PR final review.

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dukenv0307]

@kadiealexander @thienlnam Can you please assign me to this issue since I'm reviewer on this PR? Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Rename Money Request/Split/Pay step header names #53004

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

@c3024 @kadiealexander @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[kadiealexander]

• Contributor: @c3024 paid $250 via Upwork (Offer link)
• Contributor+: @dukenv0307 owed $250 via manual request

[kadiealexander]

@dukenv0307 please complete the checklist!

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This PR just renames the header so no need for offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/451483

Regression Test Proposal

Test:

Submit expense

1. Click Submit expense from Global Create
2. Enter amount
3. Verify Choose recipient is shown in the header
4. Select any option
5. Verify Confirm details is shown in the header

Track expense

1. Click Track expense from Global Create
2. Verify Track expense is shown in the header
3. Enter amount
4. Verify Confirm details is shown in the header

Split expense

1. Click Track expense from WS chat
2. Verify Create expense is shown in the header
3. Enter amount
4. Verify Confirm details is shown in the header

Do we agree 👍 or 👎

[dukenv0307]

@kadiealexander I completed the checklitst