[HOLD for payment 2024-11-26] [HOLD for payment 2024-11-22] [$50] Workspace- App crashes when submitting an expense in OD after creating a new Workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.62-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+shsb22cq11@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Prerequisite
Make sure you are signed in the same account in both ND and OD
You already have an existing workspace and an existing expense submitted

1. Navigate to OD
2. Create a new collect workspace
3. Navigate to expenses tab > Create a new manual expense > Finish the flow
4. Navigate to the tab where you are signed in ND

Expected Result:

App does not crash and the expense is submitted successfully

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1411_1.txt

Bug6665016_1731578815373.2024-11-14_12_36_14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857012145307783614
• Upwork Job ID: 1857012145307783614
• Last Price Increase: 2024-11-14
• Automatic offers:
• nkdengineer | Contributor | 104896419

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857012145307783614

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[mountiny]

$50 For identifying the offending pr

[melvin-bot]

Upwork job price has been updated to $50

[nkdengineer]

@mountiny It comes from here.

[nkdengineer]

The report can be undefined. We shouldn't cast the type Report[] and add a safer check when getting data from the report. I can raise a quick fix for this.

const allReports = Object.values(ReportConnection.getAllReports() ?? {});
    const potentialReports = allReports.filter((r) => r?.ownerAccountID === currentUserAccountID && (r?.stateNum ?? 0) <= 1 && r?.policyID === report.policyID);
    return potentialReports.some(
        (potentialReport) => hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport?.reportID, transactionViolations),
    );

App/src/libs/ReportUtils.ts

Lines 6353 to 6355 in 75dd17a

	const allReports = Object.values(ReportConnection.getAllReports() ?? {}) as Report[];
	const potentialReports = allReports.filter((r) => r.ownerAccountID === currentUserAccountID && (r.stateNum ?? 0) <= 1 && r.policyID === report.policyID);
	return potentialReports.some(

[mountiny]

@nkdengineer Sounds good, thanks!

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Plot twist, @allgandalf already has PR to fix this up https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1731582509875719?thread_ts=1731581014.860089&channel=C01GTK53T8Q&message_ts=1731582509.875719

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Assigning @iwiznia was he did lots of work on the linked pr

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

PR was CPed, qa will test that

[nkdengineer]

@mountiny Will I receive $50 for offending PR?

[mountiny]

Will I receive $50 for offending PR?

I think this is a thin line because the fix was already at work before you identified the PR, and in these cases, we usually do not compensate. I hope that is fine with you

[nkdengineer]

Thanks, no problem.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: fix crash on staging due to null assertion of reports #52547

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@fedirjh @greg-schroeder @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

Let's close this one, it was a deploy blocker.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: fix crash on staging due to null assertion of reports #52547

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@fedirjh @greg-schroeder @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]