[HOLD for payment 2024-12-05] [Company cards] The card name after assignment is not showing correctly

[mountiny]

Coming from here.

When admin assigns a card on the workspace the card name is not showing correctly on the card details page and we are not returning it correctly.

Also lets remove the unused card images #52389 (comment)

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[koko57]

I can work on that!

[mountiny]

Backend pr raised

[allgandalf]

Please assign me here for the FE part 👋 , worked on the previous PR related to images #52389 (comment)

[koko57]

@mountiny how will the BE fix look like?

[mountiny]

@koko57 this should be ready to test in staging. Essentially we are saving the name now for the admin's nvp, so the admins should be able to see the card names correctly after the assignment. The assignee on the other hand does not have this name, but we discussed this in slack.

@allgandalf would you be able to retest in staging?

[allgandalf]

Works great!:

Screen.Recording.2024-11-18.at.11.44.04.PM.mov

[koko57]

@mountiny so is there any change required on the FE?

[koko57]

the changes I've made for this PR make a fallback to the "[UserName]'s card". I've also noticed that for Expensify Card we have "[UserName]'s Card" with the "Card" uppercased. I checked this in the docs, the lowercased version is the proper one, sorry it's my fault. It'll be kind of a breaking change when I change it for the Exfy Card?

For the default name in the card details page - I can display the fallback name but for the Edit card name page I would do some hard logic to have it displayed as the input's default value. So does it make sense to have this fallback in place as the feature is still in beta? cc @mountiny

[mountiny]

Discussed in DM, we can change the name to card

[mountiny]

@koko57 are you going to update the card name as part of this issue?

[koko57]

yes, I can do that

[joekaufmanexpensify]

the changes I've made for this PR make a fallback to the "[UserName]'s card". I've also noticed that for Expensify Card we have "[UserName]'s Card" with the "Card" uppercased. I checked this in the docs, the lowercased version is the proper one, sorry it's my fault. It'll be kind of a breaking change when I change it for the Exfy Card?

Agree with Vit, let's change the c in card to lowercase. LMK if any other questions!

[koko57]

opening for the review (no screenshots for android though, the app is built but stuck on the SplashScreen) #52735

[allgandalf]

PR in review

[mountiny]

Merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Fix/52558 fix card name and images #52735

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @adelekennedy @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

We will handle the payments for these in bulk after the project is done, no regression tests specifically forthis change is required, we will add tests with Joe in general