[HOLD for payment 2024-11-29] Android - Expensify Card - Username, last 4 and limit amount are not aligned on the same line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+29302390@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #52529

Action Performed:

Precondition:

• Expensify Card is enabled in the workspace.
• There is at least one workspace member with virtual card

1. Launch ND or hybrid app
2. Go to workspace settings
3. Go to Expensify Card

Expected Result:

User name, last 4 digits and limit amount will be aligned on the same line

Actual Result:

User name, last 4 digits and limit amount are not aligned on the same line (please refer to screenshot)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

[NJ-2020]

I think this is the expected #52529 (comment)

[mountiny]

happy to take over as I work on this one

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[mountiny]

I agree this is not a blocker, as we made this change intentionally. However, I can see that the card name is a little bit off, imho. @Expensify/design are you able to check the images cc @nkdengineer

[dannymcclain]

I also agree this is not a blocker, but the alignment is definitely off. From Figma, the Name, Last 4, and Limit should all sit on a common baseline.

[mountiny]

@nkdengineer sorry for the trouble but this is something we did not catch in the PR so I should assign you here, can you please comment?

[nkdengineer]

I'm here

[nkdengineer]

@DylanDylann, @mountiny, @Expensify/design here is the result from my side, it seems they are not on the same line and are about 1-2px different
I will investigate and create PR to fix tomorrow

[shawnborton]

Agree with the comments above. Hopefully it's a quick fix!

[nkdengineer]

@DylanDylann, @mountiny, @Expensify/design We have open PR here

[dannymcclain]

Nice!

[mountiny]

PR merged 🎉

[mountiny]

This is good, I think no payment required on this issue as it was a regression from the PR before

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: username, last 4 and limit amount are not aligned on the same line #52743

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)
• @nkdengineer requires payment (Needs manual offer from BZ)

[mountiny]

$250 to @nkdengineer @DylanDylann for their work on this one, discussion was on this issue #52370 (comment)

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bfitzexpensify]

Offers sent @DylanDylann @nkdengineer

[melvin-bot]

@shawnborton, @mountiny, @bfitzexpensify, @DylanDylann, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Payments complete.