Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Expensify Classic opens after relaunching when New Expensify is last opened #52664

Closed
1 of 8 tasks
lanitochka17 opened this issue Nov 16, 2024 · 8 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+zm51@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch hybrid app
  2. Sign in
  3. If app lands on Expensify Classic, go to Menu > Try New Expensify
  4. If app lands on New Expensify, go to Settings > Switch to Expensify Classic
  5. On Expensify Classic, open Menu > Try New Expensify to go back to New Expensify
  6. Kill app
  7. Relaunch app

Expected Result:

New Expensify will open on hybrid app after relaunching app because New Expensify is the last opened section

Actual Result:

Expensify Classic opens on hybrid app after relaunching app when New Expensify is the last opened section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6666751_1731706307198.Bug6666735_1731706154822_Screen_Recording_20241116_052851.1.mp4
Add any screenshot/video evidence

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 16, 2024
Copy link

melvin-bot bot commented Nov 16, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 16, 2024
Copy link

melvin-bot bot commented Nov 16, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 16, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor

Working on getting access to the Android beta for OldApp

@arosiclair
Copy link
Contributor

Okay I reproduced in v9.0.63-3

@arosiclair
Copy link
Contributor

Looks like the root of this problem is that opening the new experience does not update tryNewDot.classicRedirect.dismissed to false. I'm not sure why yet.

@arosiclair
Copy link
Contributor

Okay we already merged a PR to fix it! This was caused by mixed up params that skipped updating the tryNewDot NVP from https://github.com/Expensify/Mobile-Expensify/pull/13257 and should be fixed with https://github.com/Expensify/Mobile-Expensify/pull/13286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants