Send all messages currently sent from "Expensify" from "Concierge" instead.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): Expensify_convert

Action Performed:

Example:

1. Have a user sign up for a free trial
2. Review the full story session

Expected Result:

"You've started a free trial!" message from Concierge.

Actual Result:

"You've started a free trial!" message from "Expensify" and not Concierge.

All of these messages from "Expensify" should now come from "Concierge".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence


View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858918882452697388
• Upwork Job ID: 1858918882452697388
• Last Price Increase: 2024-11-19

Issue Owner

Current Issue Owner: @francoisl

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[jamesdeanexpensify]

Actually @m-natarajan @twisterdotcom could we instead turn this issue toward ensuring that no more messaging is coming from the "Expensify" DM at all?

It should all be coming from Concierge, but I've seen some other recent instances where the Expensify DM is in the LHN of member accounts (during Fullstory reviews), so we figured a general sweep would be worth it. Thank you! cc @danielrvidal for visibility

[twisterdotcom]

Sure, we can just make this a NewFeature to ensure everything that was previously sent by "Expensify" is sent by "Concierge" instead.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858918882452697388

[melvin-bot]

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[melvin-bot]

Upwork job price has been updated to $500

[twisterdotcom]

Making it $500 as this will likely be involved.

[twisterdotcom]

@jamesdeanexpensify which project should we put this in?

[jamesdeanexpensify]

Heads up - dropped a post here to align on some things before moving forward.

[francoisl]

@jamesdeanexpensify is this a generalization of #52077 to any message and not just "You've started a free trial!"? Maybe we can close that other issue and continue here?

I already commented in the other issue here, but I think this might need to be internal, although it would be great if someone else has other examples of similar messages we currently send in the Expensify DM, so we can double-check.

[jamesdeanexpensify]

Yes, that's a good way to put it. This issue is a generalization of #52077 to any messages sent by the Expensify DM that should instead be sent by Concierge.

So I agree with your thoughts on closing the other issue out! I'll propose it in that issue. Let's continue here.

[jamesdeanexpensify]

Going to also paste what @francoisl said in the other issue because I think it's relevant:

I think this might need to be internal, I can only find references of the the "You've started a free trial" in the backend, which could imply that we don't create that notification optimistically from the client.

We'll most likely need to update this piece of code so it no longer uses getNotificationsAccountID, and also review everywhere else we still use it.

I'll keep an eye on this issue and try to pick it up after I finish a few ongoing tasks, if no one else does by then.

He also noted in the Slack convo that, in addition to the "You've started a free trial" message, the "Thanks for adding a payment card!" message would also be affected by the change from Expensify DM to Concierge (it should rightfully be sent by Concierge, as well).

[francoisl]

@jamesdeanexpensify should this message when you upgrade a workspace also show as coming from Concierge?

[jamesdeanexpensify]

@garrettmknight do you have the answer to the question above? I feel like we worked on that message together in some thread in the past months. It shouldn't come from the Expensify DM anymore. I'm assuming it should come from Concierge, but just want to double check in case I'm missing something (like it should be posted in the #admins room instead, or something). Thanks!

[francoisl]

Yeah to be clear, at the moment it doesn't come in the Expensify DM, just from the Expensify "persona". The message itself is posted in the admins room though.

[jamesdeanexpensify]

Looking back at this thread, it seems fine to come from "Expensify" in this case. (cc @garrettmknight that thread looks like it never closed out properly though, just a heads up!)

[jamesdeanexpensify]

Chatting here: https://expensify.slack.com/archives/C07HPDRELLD/p1732658549995089?thread_ts=1732488587.126109&cid=C07HPDRELLD