[HOLD] [iOS] Figure out why setTimeout is needed when viewing SidebarScreen on load, replace with better solution

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Remove setTimeout from this code
2. Set isActive={true} there so the global create menu should show immediately
3. Rebuild app
4. Close app completely on iOS simulator
5. Reopen app

Expected Result:

Global create menu should show up. Since it doesn't, we were forced to introduce a 200ms timeout here, but we want to understand why & how to remove that and still make the global create menu display when a new expensify user opens the app for the first time (unless they already have a workspace)

Actual Result:

Global create menu doesn't show up

See @mateomorris 's tests in this comment

Workaround:

Keep the code as it is, it works but we don't know why it's necessary 👎

Possible solutions / ideas so far

1. Idea from @marcaaron here
2. Some notes from @mateomorris in his comment here

Platform:

Where is this issue occurring?

• iOS

Version Number: latest
Notes/Photos/Videos: Any additional supporting documentation
Issue reported by: @mateomorris here
Slack conversation: N/A

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kadiealexander]

Upwork job: https://www.upwork.com/jobs/~01e9442bc5ff417a90

[Spider3dev]

@Beamanator
I think it will be fixed in this way.

if (!hasFreePolicy) { // For some reason, the menu doesn't open without the timeout setTimeout(() => { this.toggleCreateMenu(); }, 200); }

!hasFreePolicy && this.toggleCreateMenu();

Thanks.

[Beamanator]

@nhanth1012 please add more detail and explanation to your proposal. Why do you think that will fix the issue?

Also, are you recommending replacing the entire if-statement with !hasFreePolicy && this.toggleCreateMenu();? This doesn't follow our style guidelines, and I don't believe it will help us because the setTimeout is the only way we got this to work without changing code elsewhere

[Spider3dev]

@Beamanator
I think you want me to remove the setTimeout from the code. right?
Of course, I will consider your suggestion carefully.

[Beamanator]

@nhanth1012 Ideally yes, or if setTimeout is absolutely necessary here, we would like to know why and document it. Thanks 🙏

[roryabraham]

I think that a valuable next-step for this issue would be to take some lessons/evidence from this issue and submit a detailed bug report to react-navigation with a minimal reproduction of the issue. From there, we can see what activity the issue generates/whether the maintainers pick it up or whether we should investigate the possibility of submitting a fix ourselves.

[kadiealexander]

N6 hold is still applied this week.

[Beamanator]

This could be another candidate for getting assistance after sponsoring react-navigation (https://github.com/Expensify/Expensify/issues/179779)

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[Beamanator]

Back at it after a busy last week, will try to get this done the upcoming week

[kadiealexander]

Not overdue Melvin, please go away!

[kadiealexander]

@Beamanator do you have any update on this one?

[Beamanator]

I'm dropping this to Monthly since I've got a bunch of other priorities at the moment, I'll try to take a look this month

[Beamanator]

Haven't gotten to this yet, other priorities keep popping up

[Beamanator]

Not top priority still

[Beamanator]

Still in the middle of some high priory tasks (currently Offline First doc)

[tgolen]

// This is a short-term workaround

This is precisely why we shouldn't ever put these comments in the code 😬

[Beamanator]

So true 😅 🤦