[HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] Android Hybrid - Login - Blank page if logging in via Magic Link and crash if resending link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): ibellicotest+35@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Log out from the account.
3. Tap on "Log In"
4. Complete with any account and tap on "Next"
5. Wait for the Email with Magic Code and Magic Link to arrive.
6. Open the Email and tap on "Click this Magic Link"
7. Verify you are redirected to the app again and logged in to the account.

Expected Result:

The user should be logged in to the chosen account after tapping on "Click on this Magic Link" on the received Email.

Actual Result:

When the user receives Email with Magic Code and Magic Link and taps on "Click on this Magic Link" to log in to the account, a blank page is displayed when redirected to app. After killing the app, re opening it and tapping on "Didn´t receive Magic Code?", the app crashes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2311_1.txt

Bug6674263_1732375389900.Magic_Link.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mateuuszzzzz]

Hi @IuliiaHerets! What is your OS version and device model? It would greatly help in identifying the root cause in Crashlytics.

[mountiny]

the device used was: Motorola Moto G60 - Android 12

[mountiny]

Seems like not a backend issue

[garrettmknight]

@mountiny should we assign @war-in or yourself to this one since you're actively working on it?

[srikarparsi]

I added @mountiny, this is the slack thread, I think we're just checking to make sure this PR doesn't break anything on IOS

[mountiny]

PR looks promising so moving it to staging to thoroughly test

[mountiny]

Fix CPed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [HybridApp] Fix deeplinks when clicking on app icon #53074

If no regressions arise, payment will be issued on 2024-12-03. 🎊

[melvin-bot]

@mountiny / @srikarparsi @garrettmknight @mountiny / @srikarparsi The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] [HybridApp] Fix deeplinks when clicking on app icon #53074

If no regressions arise, payment will be issued on 2024-12-05. 🎊

[melvin-bot]

@mountiny / @srikarparsi @garrettmknight @mountiny / @srikarparsi The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

This was fixed by changes in the oldApp as we enabled deeplinks for the hybrid app. SWM was aware of these changes, no regression tests required, noone to pay either