[HOLD for payment 2021-10-07] Use number pad keyboard when field input will only include numbers in VBA flow

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem

The keyboard does not "match" certain fields that should only include numbers within the VBA flow, which requires users to tap through to numbers within their keyboard manually. Here is where this occurs:

Company Information Step

• Zip Code
• Incorporation Date

Personal Information Step

• DOB
• SSN
• Zip Code

Action Performed:

1. Create workspace
2. Go through VBA flow with test credentials

Solution

Use the number pad whenever a field within the VBA flow will only include digits, like so:

Platform:

• iOS
• Android

Reproducible in staging?: Yes
Reproducible in production?: Yes

Notes/Photos/Videos:

We should use the number pad in scenarios like this one:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[thesahindia]

Proposal

Adding keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD} on the respective ExpensiTextInput(s) should fix this issue.

[JmillsExpensify]

Upwork job is here: https://www.upwork.com/jobs/~010b5eef0fab29284e

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Jag96 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Jag96]

@kevinksullivan it looks like we ask for hyphens for Incorporation Date in the field label seen below, I think we should use a different keyboard type for that one.

@thesahindia your proposal makes sense for the fields except for Incorporation Date since there is no hyphen for number pad on iOS. Can you propose a different keyboardType for that one to ensure it can be filled out on iOS?

[Santhosh-Sellavel]

@Jag96

Proposal

We need to use keyBoardType

For fields DOB, Incorporation Date -

iOS - numbers-and-punctuation
Android - numeric or phone-pad

We can write a new method getDateKeyboardType in libs folder to get approritate keyboardType for platforms.
Implementation like we already do for getEmailKeyboardType
Or even simpler one like this -> getOperatingSystem

For other fields

numeric or phone-pad is enough, we can use the existing constants

[thesahindia]

@thesahindia your proposal makes sense for the fields except for Incorporation Date since there is no hyphen for number pad on iOS. Can you propose a different keyboardType for that one to ensure it can be filled out on iOS

I think we can just leave it as it is for now it is already being handled here

[JmillsExpensify]

@Jag96 I agree with @thesahindia. We already have a separate issue for that one

[Jag96]

Sounds good, @thesahindia your proposal looks good then, feel free to start on a PR once you've been hired in Upwork. @JmillsExpensify let's hire @thesahindia for this one.

[thesahindia]

Upwork job is here: https://www.upwork.com/jobs/~010b5eef0fab29284e

Hey @JmillsExpensify, I think this job is for an another issue:#5303

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.3-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pulls/5513\n

If no regressions arise, payment will be issued on 2021-10-07. 🎊

[thesahindia]

Hi team, I couldn't find the job for this issue on Upwork.

cc: @JmillsExpensify @Jag96

[Jag96]

@thesahindia I couldn't find it either, I just created a new posting and invited you, thanks for the heads up! https://www.upwork.com/jobs/~01a1e4563f1db799d8

[Jag96]

Paid!