[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Search - Group chat preview shows "Group" (email for 1:1 DM) instead of latest message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.68-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+kh1211006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a group chat.
3. Send a message in the group chat.
4. Open search router.
5. Look for the group chat.

Expected Result:

Group chat preview will show the latest message.

Actual Result:

Group chat preview shows "Group" instead of latest message.

For 1:1 DM, it shows the user email instead of the latest message.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679497_1732827030222.20241129_044843.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production

[aldo-expensify]

Reproduced in staging, confirmed that in production it doesn't happen

[aldo-expensify]

App/src/libs/OptionsListUtils.ts

Lines 443 to 445 in 03639a9

	if (isGroupChat) {
	return showChatPreviewLine && formattedLastMessageText ? formattedLastMessageText : Localize.translate(preferredLocale, 'common.group');
	}

showChatPreviewLine: false
formattedLastMessageText: 'asdasd'

Seems like showChatPreviewLine has the wrong value?

Stack:

[aldo-expensify]

I believe this may have been caused by: #52568

[aldo-expensify]

@Kicu @SzymczakJ are you around for taking a look at this? 🙏

[aldo-expensify]

I'm not sure if the solution could be simply as #53293 or if that would break something

[aldo-expensify]

@hannojg / @ahmedGaber93 , since you worked here in something very related #53056, would you happen to know if this change #53293 makes sense to fix this? 🙇

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[aldo-expensify]

Probably the same root cause as #53289

[aldo-expensify]

Made the PR ready for review: #53293

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix chat view in search router #53293

If no regressions arise, payment will be issued on 2024-12-07. 🎊

[melvin-bot]

@aldo-expensify @jliexpensify @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jliexpensify]

No payment or checklist needed here, correct @aldo-expensify?

[aldo-expensify]

No payment or checklist needed here, correct @aldo-expensify?

Correct

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix chat view in search router #53293

If no regressions arise, payment will be issued on 2024-12-09. 🎊

[melvin-bot]

@aldo-expensify @jliexpensify @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]