[HOLD for payment 2024-12-17] Thread - Thread title in report details RHP shows the entire message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.68-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+232803@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a long message.
4. Right click on the message > Reply in thread.
5. Click on the thread header.

Expected Result:

The thread title in report details RHP should have limit for the lines it will display.

Actual Result:

The thread title in report details RHP shows the entire message and user has to scroll down to see the buttons.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679791_1732870553838.20241129_165149.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

This seems to come from #53041

We are setting numberOfLinesTitle={0} here, because of that the number lines are not truncated

App/src/pages/ReportDetailsPage.tsx

Line 747 in 4206c86

numberOfLinesTitle={0}

we should set it to 2 to truncate it to 2 lines, or remove the numberOfLinesTitle prop to truncate it to one line

[twilight2294]

Raising a fix now

[mountiny]

@twilight2294 are you in Slack?

[mountiny]

@twilight2294 its not clear what the fix is, we should discuss with the design team

[twilight2294]

@twilight2294 are you in Slack?

Waiting to get added

[mountiny]

We will revert @twilight2294 and then you can handle this case in the PR again and discuss with the design team the best course of action, no need to rush to some solutions we do not have agreement on 👍

[twilight2294]

No problem!, Should I put up a revert PR ?

[mjasikowski]

Revert PR on the way

[mjasikowski]

Revert PR merged, CP request sent

[jjcoffee]

@Expensify/design Do you have any thoughts on how to display the thread title in the report details RHP? Specifically should it be truncated, and to how many lines?

For context: In #52836 we were going to display report titles full-length, since rooms and groups have a natural length limit. For threads though the title length is pretty much unlimited, so we probably want to handle it differently.

[shawnborton]

I think we can just pick a reasonable limit, something that might feel similar to the character-enforced limit we use elsewhere. So maybe that should be like 2-3 lines or something?

Are we able to pick an amount of lines and truncate that way?

[dannymcclain]

I agree with Shawn—2-3 lines seems totally reasonable to me. If we can't pick the amount of lines, I bet we can estimate a character length that gives us something similar.

[jjcoffee]

Thanks for the feedback, guys! We can indeed just choose the number of lines and truncate based on that.

@twilight2294 Could you proceed with 2 lines and we'll see how that looks?

[twilight2294]

I will have a PR up tomorrow, sorry missed this today

[twilight2294]

@jjcoffee just to be sure, I have a draft up, can you please check if that is what we need?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Room name displayed truncated on header and details when using long name & Limit thread heading to two lines #53553

If no regressions arise, payment will be issued on 2024-12-17. 🎊

[melvin-bot]

@mjasikowski @sonialiap @mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sonialiap]

I'm OOO Dec 16-20, adding a leave buddy

next steps:
@joekaufmanexpensify adding you directly since this cropped up from PR for #52836. I don't believe a payment will be needed here because the original issue hasn't been paid but adding a buddy just in case

[joekaufmanexpensify]

Correct, this was a regression from my issue. No payment will be needed here.