Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] The central page page is not rendered when resized to narrow and then to wide view again #53445

Closed
8 tasks
mountiny opened this issue Dec 3, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Dec 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @WojtekBoman
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

  1. go to workspace settings
  2. Select the workspace profile page
  3. Resize the window to the narrow view
  4. Go back to the workspace LHN
  5. Resize the view to wide view
  6. Notice that the central pane content is blank

Expected Result:

Describe what you think should've happened

The profile page should be shown there

Actual Result:

Describe what actually happened

Black page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Screen.Recording.2024-12-03.at.12.23.55.mov

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 3, 2024
@mountiny mountiny self-assigned this Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@WojtekBoman
Copy link
Contributor

Hi! I'd like to work on this issue :)

@FitseTLT
Copy link
Contributor

FitseTLT commented Dec 3, 2024

Don't you guys think this is a dupe of #53395

@mountiny
Copy link
Contributor Author

mountiny commented Dec 3, 2024

Hmm yeah that is the same, I did not see that issue before.

@ntdiary
Copy link
Contributor

ntdiary commented Dec 3, 2024

Don't you guys think this is a dupe of #53395

Yep, We got two similar proposals in issue #53395 (i.e., subscribe to narrowLayout in WorkspaceInitialPage and then try to redirect to Profile). While they can work, my intuition tells me there could be a better solution. 😂

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 3, 2024
@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 3, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title The central page page is not rendered when resized to narrow and then to wide view again [HOLD for payment 2024-12-20] The central page page is not rendered when resized to narrow and then to wide view again Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 13, 2024

@mountiny @adelekennedy @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor Author

We have automated test for this and the payment will be handled on this issue #53395

We can close now - This came from the native stack PR

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Dec 13, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants