-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Bump the react-native-pager-view to remove patch #53543
Comments
Triggered auto assignment to @muttmuure ( |
Hey hey, Its Sysu from Callstack and I would like to work on that issue! |
Hey hey, working on opening the PR, making sure that there are no regressions. |
@MrRefactor, @mountiny, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Job added to Upwork: https://www.upwork.com/jobs/~021866073165893456604 |
@MrRefactor What is your eta for this? |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
Hey @mountiny while testing changes I found regression on android on the latest version. Can we put this issue |
@MrRefactor Do you have an issue created upstream so I can link it to something specific? |
Created a draft PR with changes, I will bump the version to 6.6.2 as soon as I fix the issue upstream and release a new version |
@MrRefactor should we go ahead and test the PR with the patch or should we wait? |
There is no patch for the crash yet |
ah misread, will wait then! |
@akinwale, @MrRefactor, @mountiny, @muttmuure Eep! 4 days overdue now. Issues have feelings too... |
Update - still fixing upstream |
Problem
Expensify currently uses react-native-pager-view version 6.5.1 with a patch for it.
Solution
Upgrade react-native-pager-view to version 6.6.1 and remove patch as fixes were merged upstream.
Version 6.6.1 also allows us to remove useNext={shouldUseNewPager()} platform specific code as useNext prop was removed.
Issue Owner
Current Issue Owner: @MrRefactorUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: