Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Bump the react-native-pager-view to remove patch #53543

Open
mountiny opened this issue Dec 4, 2024 · 16 comments
Open

[$250] Bump the react-native-pager-view to remove patch #53543

mountiny opened this issue Dec 4, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@mountiny
Copy link
Contributor

mountiny commented Dec 4, 2024

Problem

Expensify currently uses react-native-pager-view version 6.5.1 with a patch for it.

Solution

Upgrade react-native-pager-view to version 6.6.1 and remove patch as fixes were merged upstream.
Version 6.6.1 also allows us to remove useNext={shouldUseNewPager()} platform specific code as useNext prop was removed.

Issue OwnerCurrent Issue Owner: @MrRefactor
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866073165893456604
  • Upwork Job ID: 1866073165893456604
  • Last Price Increase: 2024-12-09
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2024
@mountiny mountiny self-assigned this Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MrRefactor
Copy link
Contributor

Hey hey, Its Sysu from Callstack and I would like to work on that issue!

@MrRefactor
Copy link
Contributor

Hey hey, working on opening the PR, making sure that there are no regressions.

Copy link

melvin-bot bot commented Dec 9, 2024

@MrRefactor, @mountiny, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 9, 2024
@melvin-bot melvin-bot bot changed the title Bump the react-native-pager-view to remove patch [$250] Bump the react-native-pager-view to remove patch Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866073165893456604

@mountiny
Copy link
Contributor Author

mountiny commented Dec 9, 2024

@MrRefactor What is your eta for this?

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
@MrRefactor
Copy link
Contributor

Hey @mountiny while testing changes I found regression on android on the latest version. Can we put this issue on hold and after I fix it upstream we will go with merging it?

@mountiny
Copy link
Contributor Author

mountiny commented Dec 9, 2024

@MrRefactor Do you have an issue created upstream so I can link it to something specific?

@MrRefactor
Copy link
Contributor

@MrRefactor
Copy link
Contributor

Created a draft PR with changes, I will bump the version to 6.6.2 as soon as I fix the issue upstream and release a new version

@mountiny
Copy link
Contributor Author

@MrRefactor should we go ahead and test the PR with the patch or should we wait?

@MrRefactor
Copy link
Contributor

@MrRefactor should we go ahead and test the PR with the patch or should we wait?

There is no patch for the crash yet

@mountiny
Copy link
Contributor Author

ah misread, will wait then!

Copy link

melvin-bot bot commented Dec 16, 2024

@akinwale, @MrRefactor, @mountiny, @muttmuure Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@MrRefactor
Copy link
Contributor

Update - still fixing upstream

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Development

No branches or pull requests

4 participants