[HOLD for payment 2024-12-30] [$125] Inconsistency on bottom padding for submit button in issue expensify card flow

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @koko57
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

1. Submit a physical card
2. Notice the gap in the Issue Card button from the bottom
3. compare it with the Submit button on the validate magic code

Expected Result:

Describe what you think should've happened

The submit button should have the same bottom padding everywhere

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865895438137903488
• Upwork Job ID: 1865895438137903488
• Last Price Increase: 2024-12-08
• Automatic offers:
• allgandalf | Reviewer | 105306702
• Krishna2323 | Contributor | 105306704

Issue Owner

Current Issue Owner: @johncschuster

[mountiny]

cc @koko57

[koko57]

I would like to work on this issue 🙂

[mountiny]

@koko57 how is this looking?

[mountiny]

We can make this external too

[koko57]

I will work on it on Monday, today Im ooo

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021865895438137903488

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Not overdue looking for proposals

[Krishna2323]

@allgandalf PR ready for review ^

[allgandalf]

♻️ PR was merged

[allgandalf]

♻️ PR is on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Inconsistency on bottom padding for submit button in issue expensify card flow. #54164

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment automatic offer (Contributor)
• @allgandalf requires payment automatic offer (Reviewer)
• @koko57 does not require payment (Contractor)

[melvin-bot]

@allgandalf @johncschuster @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: @koko57

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/48628/files#r1896463257

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I don't think we need a regression test here, it was a styling issue and something we would require specific tests for!

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[allgandalf]

@mountiny I don't think we would need a regression test for a styling issue, let me know if you think otherwise

[mountiny]

I agree with that

[allgandalf]

not overdue

[melvin-bot]

@johncschuster, @mountiny, @Krishna2323, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster, @mountiny, @Krishna2323, @allgandalf Still overdue 6 days?! Let's take care of this!

[johncschuster]

Hey folks! I'm back from OOO and will work on issuing payment now. Thanks for your patience!

[johncschuster]

@Krishna2323, can you please accept the job on Upwork?

[johncschuster]

I've issued payment to @allgandalf and will issue payment to @Krishna2323 once the job has been accepted 👍

[Krishna2323]

@johncschuster I have accepted the offer, thanks.