Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections #53759

Closed
mountiny opened this issue Dec 9, 2024 · 38 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Dec 9, 2024

This is a request from @dubielzyk-expensify to add animation to the expanding section in Workflows (and other similar places in the app) where after toggling the switch, we open the section like this https://github.com/user-attachments/assets/43e48c18-6b18-4ec6-bc7f-3238f125d616

cc @sumo-slonik @blazejkustra would like to implement this - can you please comment

@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866452926963427651
  • Upwork Job ID: 1866452926963427651
  • Last Price Increase: 2024-12-10
Issue OwnerCurrent Issue Owner: @stephanieelliott
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. Design labels Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 9, 2024

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@dubielzyk-expensify
Copy link
Contributor

@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?

Let's start with an ease-out and see how that feels. Excited about this :)

@sumo-slonik
Copy link
Contributor

Hi, I am very eager to get started on this :)
I have an idea how to do it using reanimated and I'm already on it

@shubham1206agra
Copy link
Contributor

Assign me here for review please.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 10, 2024
@melvin-bot melvin-bot bot changed the title Implement animation to the switch expandable sections [$250] Implement animation to the switch expandable sections Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866452926963427651

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 10, 2024
@mountiny
Copy link
Contributor Author

I think we can just use the autoassigner, its a new task and no rush

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 10, 2024
@sumo-slonik
Copy link
Contributor

Is already working, I am checking where in other places of the application could be used such acordition element with switch

Screen.Recording.2024-12-10.at.16.37.49.mov
Screen.Recording.2024-12-10.at.16.39.02.mov

@mountiny
Copy link
Contributor Author

@sumo-slonik we also use it in accounting settings

@mountiny
Copy link
Contributor Author

you have to connected to QBO for example

Copy link

melvin-bot bot commented Jan 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 21, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thesahindia] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Copy link

melvin-bot bot commented Jan 28, 2025

Payment Summary

Upwork Job

  • Contributor: @sumo-slonik is from an agency-contributor and not due payment
  • Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1866452926963427651/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@sumo-slonik
Copy link
Contributor

We are continuing to wait here for the tick under the new PR after the reverting of the previous one, so we should not mark it as ready yet.

@stephanieelliott
Copy link
Contributor

Updating labels to remove payment status, seeing as we're still waiting on the second PR: #55412

@stephanieelliott stephanieelliott changed the title [HOLD for payment 2025-01-28] [$250] Implement animation to the switch expandable sections [$250] Implement animation to the switch expandable sections Jan 29, 2025
@stephanieelliott stephanieelliott added Weekly KSv2 and removed Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jan 29, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2025
@melvin-bot melvin-bot bot changed the title [$250] Implement animation to the switch expandable sections [HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 31, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thesahindia] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor Author

The blockers were handled

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Jan 31, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Payment Summary

Upwork Job

  • Contributor: @sumo-slonik is from an agency-contributor and not due payment
  • Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1866452926963427651/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@stephanieelliott
Copy link
Contributor

Summarizing payment on this issue:

@thesahindia
Copy link
Member

@stephanieelliott, we are still working on it. There is one more PR, as the fix was split into two PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

7 participants