-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections #53759
Comments
Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new. |
Triggered auto assignment to @stephanieelliott ( |
Let's start with an |
Hi, I am very eager to get started on this :) |
Assign me here for review please. |
Job added to Upwork: https://www.upwork.com/jobs/~021866452926963427651 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
I think we can just use the autoassigner, its a new task and no rush |
Is already working, I am checking where in other places of the application could be used such acordition element with switch Screen.Recording.2024-12-10.at.16.37.49.movScreen.Recording.2024-12-10.at.16.39.02.mov |
@sumo-slonik we also use it in accounting settings |
you have to connected to QBO for example |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-28. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@stephanieelliott)
|
We are continuing to wait here for the tick under the new PR after the reverting of the previous one, so we should not mark it as ready yet. |
Updating labels to remove payment status, seeing as we're still waiting on the second PR: #55412 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The blockers were handled |
Payment Summary
BugZero Checklist (@stephanieelliott)
|
Summarizing payment on this issue:
|
@stephanieelliott, we are still working on it. There is one more PR, as the fix was split into two PRs |
This is a request from @dubielzyk-expensify to add animation to the expanding section in Workflows (and other similar places in the app) where after toggling the switch, we open the section like this https://github.com/user-attachments/assets/43e48c18-6b18-4ec6-bc7f-3238f125d616
cc @sumo-slonik @blazejkustra would like to implement this - can you please comment
@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliottThe text was updated successfully, but these errors were encountered: