Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$75] IOS Hybrid - Copilot - Not so fast modal becomes translucent on security page #53833

Closed
1 of 8 tasks
IuliiaHerets opened this issue Dec 10, 2024 · 21 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.73-6
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #52103
Email or phone of affected tester (no customers): nathanmulugetatesting+2373@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition: Sign in with a copilot account

  1. Open Expensify hybrid app
  2. Navigate to settings > Security
  3. Tap on Two factor authentication
  4. Once the Not so fast modal shows up quickly close it and tap on Close account
  5. Do step 3 and 4 quickly until issue is seen (Mostly seen after 4-5 tries)

Expected Result:

Not so fast modal background doesn't change

Actual Result:

Not so fast modal background becomes translucent

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6689854_1733823616000.ScreenRecording_12-10-2024_12-32-54_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866868576432748214
  • Upwork Job ID: 1866868576432748214
  • Last Price Increase: 2025-01-01
Issue OwnerCurrent Issue Owner: @allroundexperts
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@twisterdotcom
Copy link
Contributor

Once the Not so fast modal shows up quickly close it and tap on Close account
Do step 3 and 4 quickly until issue is seen (Mostly seen after 4-5 tries)

I don't think we should be blocking a deploy on incredibly unlikely user behaviour like this. I am fine with understanding the issue and fixing it if we truly care (I don't personally think we should). @grgia intrigued for your take too.

@luacmartins
Copy link
Contributor

I agree. Removing the blocker label

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 10, 2024
@grgia
Copy link
Contributor

grgia commented Dec 11, 2024

Yep thank you!

@grgia grgia added the External Added to denote the issue can be worked on by a contributor label Dec 11, 2024
@melvin-bot melvin-bot bot changed the title IOS Hybrid - Copilot - Not so fast modal becomes translucent on security page [$250] IOS Hybrid - Copilot - Not so fast modal becomes translucent on security page Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866868576432748214

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

Copy link

melvin-bot bot commented Dec 17, 2024

@twisterdotcom, @allroundexperts, @grgia Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Dec 17, 2024
@twisterdotcom
Copy link
Contributor

Can we close this?

@grgia
Copy link
Contributor

grgia commented Dec 18, 2024

@twisterdotcom the bug still exists, I'll just lower the bounty to reflect the priority and add help wanted label.

@grgia grgia changed the title [$250] IOS Hybrid - Copilot - Not so fast modal becomes translucent on security page [$75] IOS Hybrid - Copilot - Not so fast modal becomes translucent on security page Dec 18, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

Upwork job price has been updated to $75

@grgia grgia removed the Overdue label Dec 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

@twisterdotcom, @allroundexperts, @grgia Still overdue 6 days?! Let's take care of this!

@twisterdotcom
Copy link
Contributor

Making weekly

@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2024
@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Dec 19, 2024
@QichenZhu
Copy link
Contributor

Similar to #51869.

I'm guessing regular contributors can't work on this since it's a hybrid app issue, right?

Copy link

melvin-bot bot commented Dec 24, 2024

@twisterdotcom @allroundexperts @grgia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
Copy link

melvin-bot bot commented Jan 1, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@twisterdotcom
Copy link
Contributor

Going to close.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants