[HOLD for payment 2024-12-30] [$250] Fix OldDot invoice title in NewDot

[cristipaval]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name):

Action Performed:

1. Create an invoice in OldDot
2. Open the invoice in NewDot

Expected Result:

The invoice title should be the same in the header of the invoice report page, in the RHN, and when it is edited. It should be the same as in OldDot.

Actual Result:

The report title is not correct in the report page header, and the RHN.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866802844168681142
• Upwork Job ID: 1866802844168681142
• Last Price Increase: 2024-12-11

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866802844168681142

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[twisterdotcom]

@rezkiy37 do you want to take fixing the ability to edit too as we have in #53694?

[rezkiy37]

@twisterdotcom, yes I do. These issues have the same root cause.

[rezkiy37]

Preparing a PR - #54031.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use reportName for invoice reports #54031

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@dukenv0307 @alexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

• Precondition: have a workspace with enabled invoices. Admin is logged in ND and OD.

1. In OD: Submit a invoice to anyone with at least 2 expenses.
2. In ND: Navigate to the Search page.
3. Click on Invoices.
4. Click on the "Outstanding" filter.
5. Click on the “View” button next to the report that has the 2 expenses grouped.
6. Verify the the report view is displayed and the 2 expenses are visible.

Do we agree 👍 or 👎

[alexpensify]

Payment due date: 2024-12-30

Contributor: @rezkiy37 contractor
Contributor+: @dukenv0307 owed $250 via NewDot

---

@dukenv0307, please submit a request in Chat for payment. Since I'm out of the office until January 3, I'll close and work on the QA step when I'm back online.

[alexpensify]

@dukenv0307, after looking over this one more, I think it's a duplicate of #53694. Can you please confirm if a payment is due here or if there is another PR other than #54031? Thanks!

[dukenv0307]

@alexpensify I don't need to be paid for this.