Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-25] Hybrid Android - App crashes on launching #53987

Closed
1 of 8 tasks
IuliiaHerets opened this issue Dec 12, 2024 · 17 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

  1. Launch hybrid Android app.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6691708_1733977412090!log.txt

Bug6691708_1733970342503.1733968628419_Screen_Recording_20241212_095624_One_UI_Home.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Our prod version from PlayStore is 9.0.73-8

screen-20241212-091554.mp4

@lakchote
Copy link
Contributor

Raised a discussion here.

@Julesssss
Copy link
Contributor

Firebase crash logs.

Fatal Exception: java.lang.RuntimeException: undefined is not an object (evaluating 'Store.ReportHistory.bindCacheClearingEvents') at position 81:24 in app/expensify.js
Expensify@app/expensify.js:81:24
getInstance@app/expensify.js:590:44
main@app/main.js:4:36
onAllFilesIncluded@app/yapl/Yapl.js:244:21
onAllFilesIncluded@[native code]
yaplIncludeFiles@app/yapl/Yapl.js:51:17
init@app/yapl/Yapl.js:246:25
global code@YAPL-Platform:1:10
       at yapl.android.Yapl.handleJSException(Yapl.java:624)
       at yapl.android.Yapl.js_evaluate(Yapl.java:573)
       at yapl.android.Yapl.js_evaluate(Yapl.java:556)
       at yapl.android.Yapl.setActiveActivity(Yapl.java:765)
       at yapl.android.YaplActivityBase.onStart(YaplActivityBase.java:379)
       at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1583)
       at android.app.Activity.performStart(Activity.java:8647)
       at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3826)
       at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:230)
       at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:210)
       at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:182)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:103)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2462)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:205)
       at android.os.Looper.loop(Looper.java:294)
       at android.app.ActivityThread.main(ActivityThread.java:8256)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:557)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:993)
        

@Julesssss
Copy link
Contributor

We've seen this Yapl issue before and I'm almost certain it's because we're failing to build JS. Here's what we need to be doing as part of the build process.

11-27 15:49:02.427 10958 10958 E AndroidRuntime: java.lang.RuntimeException: undefined is not an object (evaluating 'Store.ReportHistory.bindCacheClearingEvents') at position 81:24 in app/expensify.js

Fix:
npm run grunt:build:shared

@Julesssss Julesssss added Monthly KSv2 and removed Hourly KSv2 Monthly KSv2 labels Dec 12, 2024
@Julesssss
Copy link
Contributor

Here's my WIP PR. I think some small path changes here will resolve the issue 🤞

@Julesssss
Copy link
Contributor

@Julesssss
Copy link
Contributor

Fixed as of 9.0.75.1.

Screenshot_20241212_151040

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2024
@Julesssss Julesssss added the Reviewing Has a PR in review label Dec 12, 2024
@Julesssss
Copy link
Contributor

QA verified fixed here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title Hybrid Android - App crashes on launching [HOLD for payment 2024-12-20] Hybrid Android - App crashes on launching Dec 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

Copy link

melvin-bot bot commented Dec 13, 2024

@Julesssss @CortneyOfstad @Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss Julesssss changed the title [HOLD for payment 2024-12-20] Hybrid Android - App crashes on launching Hybrid Android - App crashes on launching Dec 16, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 18, 2024
@melvin-bot melvin-bot bot changed the title Hybrid Android - App crashes on launching [HOLD for payment 2024-12-25] Hybrid Android - App crashes on launching Dec 18, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-25. 🎊

Copy link

melvin-bot bot commented Dec 18, 2024

@Julesssss @CortneyOfstad @Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants