Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] Track distance - Selected rate is not preserved after returning to category list #54066

Closed
8 tasks done
lanitochka17 opened this issue Dec 12, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.75-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component Money Requests

Action Performed:

Precondition:

  • Account has a workspace.
  • Workspace can have one or more distance rate.
  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Track a distance expense
  4. Click Categorize it
  5. Select a category
  6. Click Rate on the confirmation page
  7. Select any rate
  8. Click RHP back button
  9. Select any category

Expected Result:

When user has selected a workspace rate and returned to previous page to select a different category, the selected rate will not change (production behavior)

Actual Result:

When user has selected a workspace rate and returned to previous page to select a different category, the rate reverts to the individual rate
This issue does not happen when user selects a different category directly on the confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6692683_1734037048215.20241213_045049.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 12, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@paultsimura
Copy link
Contributor

paultsimura commented Dec 12, 2024

Oh gosh, I already regret taking that "Share expense" task – it just opened a can of worms 🫠
It's coming from #51517 – I will be able to take a look tomorrow morning.

@luacmartins
Copy link
Contributor

Haha I was just gonna post that it's coming from that PR. I think I'll just revert it for now since there are 2 blockers associated with it already.

@luacmartins
Copy link
Contributor

Fixed in staging

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Dec 13, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title Track distance - Selected rate is not preserved after returning to category list [HOLD for payment 2024-12-20] Track distance - Selected rate is not preserved after returning to category list Dec 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants