Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-17] Upgrade RNTL to the newest version #54210

Closed
OlimpiaZurek opened this issue Dec 16, 2024 · 10 comments
Closed

[HOLD for payment 2025-01-17] Upgrade RNTL to the newest version #54210

OlimpiaZurek opened this issue Dec 16, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@OlimpiaZurek
Copy link
Contributor

OlimpiaZurek commented Dec 16, 2024

Problem
We are currently using React Native Testing Library (RNTL) version 11.5.1, which is behind the latest version, 12.18.1. While the current version is functional, it lacks the updates, improvements, and breaking changes introduced in the newer version, particularly those focused on accessibility, API safety, and modern tooling. Staying on an outdated version risks missing these benefits and may make it harder to adopt the latest testing practices and standards.

Solution:
Upgrade to RNTL version 12.18.1 to leverage the latest features and ensure our testing practices align with modern standards

Key updates in version 12.x.x include:

  • Built-in Jest Matchers : Built-in matchers are now the recommended approach by RNTL maintainers, offering more readable tests, better accessibility support, and an improved developer experience.
  • **Query Behavior Updates : Queries like *ByText and *ByPlaceholderText now return host elements instead of React elements, ensuring consistent behavior. This aligns tests with how components behave and interact on actual devices, aligning more closely with user interactions.
  • Accessibility Improvements: For example, *ByRole queries now exclusively return elements exposed to accessibility APIs, ensuring tests align with assistive technologies like screen readers.
  • Safer APIs: The introduction of the new root API, alongside renaming container to UNSAFE_root, promotes safer and more explicit usage. The root API provides a more robust alternative for accessing the rendered output.
Issue OwnerCurrent Issue Owner: @lschurr
@OlimpiaZurek OlimpiaZurek added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@OlimpiaZurek
Copy link
Contributor Author

@mountiny I created an issue for upgrading RNTL, based on this thread on Slack:: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1732530447619079.

Here is a draft PR: #53067

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 17, 2024
@OlimpiaZurek
Copy link
Contributor Author

PR's ready for review: #53067

@OlimpiaZurek
Copy link
Contributor Author

I will be off for the next two weeks. Someone from Callstack Team will keep eye on this.

@mountiny
Copy link
Contributor

@OlimpiaZurek enjoy your holidays, can someone please sync main in the pr?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 1, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2025
@melvin-bot melvin-bot bot changed the title Upgrade RNTL to the newest version [HOLD for payment 2025-01-17] Upgrade RNTL to the newest version Jan 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 10, 2025

@mountiny @lschurr @OlimpiaZurek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 16, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@mountiny
Copy link
Contributor

all good, no tests or payments here

@github-project-automation github-project-automation bot moved this from HIGH to Done in [#whatsnext] #quality Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants