[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-24] [$250] Editing a comment: the cursor is jumping to the end of the message when we type in the middle of the text making it impossible to edit the text

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny @quinthar
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Write a message and send it
2. Go edit the message
3. Move the cursor to the middle of the text
4. Start to type

Expected Result:

User able to type where the cursor

Actual Result:

The cursor jumps to the end of the text after a first character

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-12-18.at.15.15.47.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869733355861718010
• Upwork Job ID: 1869733355861718010
• Last Price Increase: 2024-12-19

Issue Owner

Current Issue Owner: @stephanieelliott

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allroundexperts]

Seems related to the grammar extension that they're using.

[mountiny]

I do have Grammarly installed

[allroundexperts]

Can you try without that?

[mountiny]

I dont know how to write without that

[mountiny]

I cannot reproduce it now even with it on, so I will keep monitoring if it happens again

[m-natarajan]

@mountiny @allroundexperts Able to reproduce this issue in production

Recording.860.mp4

[bernhardoj]

I think this is the same as this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869733355861718010

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[mountiny]

Based on QA this is reliably repro on new accounts https://expensify.slack.com/archives/C049HHMV9SM/p1734614105597379?thread_ts=1734531561.566439&cid=C049HHMV9SM

[mountiny]

Marking this as CRITICAL quality issue as it makes the UX really bad

[ntdiary]

Marking this as CRITICAL quality issue as it makes the UX really bad

@mountiny, If this is urgent, please feel free to reassign another c+. :)

[mountiny]

Thanks! SWM will have a look in the mean time 🙌

[tomekzaw]

Someone from SWM will take a look at this shortly cc @BartoszGrajdek @Skalakid

[allroundexperts]

I can take this as I have context on it already!

[tomekzaw]

Cannot reproduce this both on new.expensify.com and staging.new.expensify.com, both on Chrome and Safari on macOS.

[stephanieelliott]

Just noting a second PR was opened and is under review: #55285

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Don't automatically unpause focus trap #54593

If no regressions arise, payment will be issued on 2025-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@allroundexperts @stephanieelliott @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1869733355861718010/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@allroundexperts, @stephanieelliott, @mountiny, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Don't automatically unpause focus trap #54593
• Update focus trap #55285

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@allroundexperts @stephanieelliott @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1869733355861718010/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @allroundexperts $250 via ND -- please request!
• Contributor+: @bernhardoj $250 via ND -- please request!

[bernhardoj]

Requested in ND.

[allroundexperts]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: As mentioned in the proposal, this was due to an issue with the focus trap library which is externally managed.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Log in to an account that has a workspace

Test:

1. Open the workspace profile page
2. Press Share button
3. Press the #admins text link. This will open the admins room
4. Focus on the composer
5. Verify the composer has a green outline
6. Send any message (if there is no message yet)
7. Right-click/long-press the message and choose Edit comment

Verify the edit composer has a green outline

8. Moves the cursor to the start of the text
9. Type anything

Verify the cursor doesn't go to the end of the text

Do we agree 👍 or 👎