[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Wallet - "phone number is not valid email address" error when activating card with phone number

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+909608@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Personal details are not filled
• User has been assigned a physical card

1. Go to staging.new.expensify.com
2. Go to Account settings > Wallet
3. Click on the physical card
4. Click Get physical card
5. Enter name > Next
6. On phone number page, enter a valid phone number from your country but without the country code
7. Proceed to confirmation page
8. Enter magic code
9. Note that the error message shows that it is not a valid email address when the phone number is used without country code and the code is valid
10. Go back to phone number page, and add a country code
11. Proceed to confirmation page
12. Enter magic code
13. Now there is no validation error when phone number with country code is used

Expected Result:

In Step 9, on confirmation page, there should be no validation error for phone number without country code since we can enter phone number without country code in Step 6

Actual Result:

In Step 9, on confirmation page, there is error for phone number without country code when we can enter phone number without country code in Step 6
Also, the validation error is incorrect as it says "phone number is not a valid email address"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6701529_1734995736864.20241224_063705.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

This is coming from my PR

cc: @sobitneupane

[NJ-2020]

I cannot reproduce this issue on the latest main

Screen.Recording.2024-12-24.at.11.57.16.mov

However I can see here that we're not appending the country code (phone number property) here inside onSubmit function

App/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx

Lines 158 to 164 in 8b7096f

	const onSubmit = useCallback(() => {
	const updatedPrivatePersonalDetails = GetPhysicalCardUtils.getUpdatedPrivatePersonalDetails(draftValues, privatePersonalDetails);
	if (isConfirmation) {
	setActionCodeModalVisible(true);
	return;
	}
	GetPhysicalCardUtils.goToNextPhysicalCardRoute(domain, updatedPrivatePersonalDetails);

App/src/libs/GetPhysicalCardUtils.ts

Lines 87 to 95 in 8b7096f

	function getUpdatedPrivatePersonalDetails(draftValues: OnyxEntry<GetPhysicalCardForm>, privatePersonalDetails: OnyxEntry<PrivatePersonalDetails>): PrivatePersonalDetails {
	const {addressLine1, addressLine2, city = '', country = '', legalFirstName, legalLastName, phoneNumber, state = '', zipPostCode = ''} = draftValues ?? {};
	return {
	legalFirstName,
	legalLastName,
	phoneNumber,
	addresses: [...(privatePersonalDetails?.addresses ?? []), {street: PersonalDetailsUtils.getFormattedStreet(addressLine1, addressLine2), city, country, state, zip: zipPostCode}],
	};
	}

[sobitneupane]

@NJ-2020 I can still reproduce the issue. But the error is different.

[NJ-2020]

@sobitneupane Can you please share the reproduction steps and also it will be good if you provide the video also?

Update: Creating the videos for the PR

[sobitneupane]

Reproduction Step:

1. Press on "Get a Physical Card" button
2. Enter the phone number. I entered an old, valid landline phone number. > Ship Card
3. Enter wrong magic code > Verify.

[NJ-2020]

@sobitneupane Do you enable staging server or not?

[jasperhuangg]

@NJ-2020 Can you finish your PR and get it ready for CP since this is still in your regression period?

[jasperhuangg]

We are reverting the original PR. It should solve the issue fully without introducing any other regressions.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix wallet phone validation page" #54585

If no regressions arise, payment will be issued on 2025-01-02. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix wallet phone validation page" #54585

If no regressions arise, payment will be issued on 2025-01-07. 🎊