-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-01-07] Workspace plan - "Collect" is not translated to Spanish #54525
Comments
Triggered auto assignment to @anmurali ( |
Triggered auto assignment to @carlosmiceli ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace plan - "Collect" is not translated to Spanish What is the root cause of that problem?We does not translate "Collect" in Spanish translation Lines 4333 to 4342 in dc784de
What changes do you think we should make in order to solve the problem?We can update the Spanish translation to "Recopilar" or another more appropriate term What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?What alternative solutions did you explore? (Optional) |
@carlosmiceli It seems the plan name was updated in Spanish after we last confirmed the name on Slack, so now update the name as per the latest es.js file on this PR #54530:
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-07. 🎊 |
@carlosmiceli @anmurali @carlosmiceli The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+909608@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
Expected Result:
"Collect" should be translated to Spanish.
Actual Result:
"Collect" is not translated to Spanish.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6701634_1735014646828.20241224_122716.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmuraliThe text was updated successfully, but these errors were encountered: