Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Composer is blocked by keyboard after changing payment method or backgrounding app #54629

Open
2 of 8 tasks
lanitochka17 opened this issue Dec 27, 2024 · 21 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.79-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+909608@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: Chat Report View

Action Performed:

Bug 1:

  1. Launch ND or hybrid app
  2. Go to workspace chat
  3. Submit an expense to the workspace chat
  4. After submitting the expense, the composer will remain focused and keyboard is not opened. Do not tap on the composer to bring up the keyboard
  5. Tap on the payment dropdown button
  6. Tap Pay with Expensify

Bug 2:

  1. Launch ND or hybrid app
  2. Open any chat
  3. Background the app
  4. Open the app

Expected Result:

When keyboard opens after changing payment button or backgrounding app, the chat will move up to give space for the keyboard and it will not block the composer

Actual Result:

When keyboard opens after changing payment button or backgrounding app, the chat does not move up and the composer is blocked by the keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6703157_1735331012810.bug_1.mp4
Bug6703157_1735331012816.BUG_2.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 27, 2024
Copy link

melvin-bot bot commented Dec 27, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 27, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@parasharrajat
Copy link
Member

May be related to #51172

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Dec 27, 2024

That sounds likely, thanks @parasharrajat. I will see if I can test out a revert on Browserstack. If not I'll request someone who has recently built Android to try it out.

@jasperhuangg
Copy link
Contributor

@neil-marcellini It isn't a straight revert sadly. If you want to do an AdHoc build I have an Android device we can use to test the revert.

@neil-marcellini neil-marcellini mentioned this issue Dec 27, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 27, 2024
@christianwen
Copy link
Contributor

I raised the PR to fix the first issue: #54651. For the second one, I can't reproduce on latest main

Copy link

melvin-bot bot commented Dec 30, 2024

📣 @christianwen! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Beamanator
Copy link
Contributor

@christianwen - please fill out your contributor details like it's stated above 🙏

Also @christianwen / @DylanDylann the fix should now be in staging! Anyone free to test?

@marcaaron
Copy link
Contributor

+1 on the above question. Seems like this is 1/2 remaining deploy blockers. Maybe QA can help test if they are around.

@isagoico
Copy link

We tried reproducing the issue on the build 9.0.79-5 and the second bug is still reproducible. Video below:

Screenrecorder-2024-12-31-09-01-03-631.mp4

@Beamanator
Copy link
Contributor

@christianwen are you still looking at the above? Please do since this is a deploy blocker 🙏

@puneetlath
Copy link
Contributor

I'm going to demote this since the remaining blocker requires killing and reopening the app, which seems less urgent to fix.

@puneetlath puneetlath added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Weekly KSv2 labels Dec 31, 2024
Copy link

melvin-bot bot commented Dec 31, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@christianwen
Copy link
Contributor

@Beamanator I can't reproduce the second bug, what about you @DylanDylann?

@DylanDylann
Copy link
Contributor

I also can't reproduce on 9.0.80-6

Screen.Recording.2025-01-04.at.05.39.26.mov

@DylanDylann
Copy link
Contributor

@isagoico Could you help to try again and provide information about your device? Thanks

@isagoico
Copy link

isagoico commented Jan 6, 2025

Issue is still reproducible on our side. Device details: Realme C67, Android 14
Here's another reproduction video:

screen-20250106-192316.mp4

@DylanDylann
Copy link
Contributor

@christianwen Could you please check this one?

@christianwen
Copy link
Contributor

@DylanDylann I'm trying to reproduce, will give an update by EOD

Copy link

melvin-bot bot commented Jan 8, 2025

@garrettmknight, @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests