[HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Track expense -Green button on confirm page shows "Create 0.00 expense" for track scan expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.81-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5421289
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open FAB.
3. Click + > Submit expense > Scan.
4. Upload a receipt.
5. Select the contact under "Personal", which is yourself.

Expected Result:

The green button on the confirmation page should be "Create expense".

Actual Result:

The green button on the confirmation page shows "Create RM0.00 expense".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6707923_1736239476465.20250107_164130.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The green button on the confirmation page shows "Create RM0.00 expense".

What is the root cause of that problem?

We're using createExpenseWithAmount in

App/src/components/MoneyRequestConfirmationList.tsx

Line 432 in 96280b8

text = translate('iou.createExpenseWithAmount', {amount: formattedAmount});

so in case amount is 0, it shows Create 0.00 expense

What changes do you think we should make in order to solve the problem?

We should update this logic to

text = translate('iou.createExpense');
            if (iouAmount !== 0) {
                text = translate('iou.createExpenseWithAmount', {amount: formattedAmount});
            }

We can use submitExpense in case amount is 0 same as here (then we can refactor code a bit to prevent duplication)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add test to verify splitOrRequestOptions function to return createExpense in this case.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

It's related to #54844 (comment) @srikarparsi

[srikarparsi]

Thanks @dukenv0307, I think we should treat this one as a blocker and not a follow up. I think the solution here is to not make those text changes for the scan flow but I'll confirm in slack.

[trjExpensify]

yep, in the scan case with Create expense regardless of which recipient you choose, we shouldn't include the amount in the button as it's unknown, so the button would just say Create expense. CC: @grgia @JKobrynski

---

Just noting the behaviour appearing on staging across the different recipient types when you use the Create expense > Scan flow:

1. When you choose a workspace, the button reads Submit expense
2. When you choose the selfDM, the button reads Create $0.00 expense
3. When you choose an individual, the button reads Submit expense

In all of these cases, the button should read Create expense because the amount is unknown in the scan flow.

[srikarparsi]

Looks like we will handle this in this PR as per this comment

[grgia]

Self assigning to keep track of this

cc @JKobrynski

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/… #54878

If no regressions arise, payment will be issued on 2025-01-15. 🎊

[melvin-bot]

@grgia / @srikarparsi @MitchExpensify @grgia / @srikarparsi The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

CC: @grgia

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[JKobrynski]

Update:

Issue fixed in #54201, waiting for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/… #54878

If no regressions arise, payment will be issued on 2025-01-17. 🎊

[melvin-bot]

@grgia / @srikarparsi @MitchExpensify @grgia / @srikarparsi The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[JKobrynski]

Update:

The PR is still waiting for review