[HOLD for payment 2025-01-28] Update task title and copy to include link to workspace settings

[jamesdeanexpensify]

Details

Coming from this convo - Whenever a workspace is created automatically as part of onboarding, the Create a workspace task will be checked off automatically. In those cases, we'd like to update that task in two ways:

1. In the task title, link on workspace to the workspace settings
2. In the task itself, update the line "Your new workspace is ready! It'll keep all of your spend (and chats) in one place." to "Your new workspace is ready! [Check it out](link to workspace settings)."

Screenshot

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

userYour proposal will be dismissed because you did not follow the proposal template.

[Shahidullah-Muffakir]

Proposal

What problem are we trying to solve?

We need to update the "Create a workspace" task to include a clickable link to the workspace settings and improve the task description

What is causing this problem?

Currently, when a workspace is automatically created as part of the onboarding process, the "Create a workspace" task is checked off by default. However, the task title and description don't include a link to the workspace settings. We need to update the task so that it includes this link and also improve the description for better clarity.
Relevant Code

What changes should we make to fix the problem?

1. Update the task title: Modify the title to include a clickable link to the workspace settings.
2. Update the task description: Change the description to make the statement about the workspace more informative and clickable.

Here's how the updated code should look:

{
    type: 'createWorkspace',
    autoCompleted: true,
    title: ({ workspaceSettingsLink }) => `Create a [workspace](${workspaceSettingsLink})`,
    description: ({ workspaceSettingsLink }) =>
        '*Create a workspace* to track expenses, scan receipts, chat, and more.\n' +
        '\n' +
        'Here’s how to create a workspace:\n' +
        '\n' +
        '1. Click the settings tab.\n' +
        '2. Click *Workspaces* > *New workspace*.\n' +
        '\n' +
        `*Your new workspace is ready! [Check it out](${workspaceSettingsLink}).`
}

3. Pass workspaceSettingsLink to the title in this part of the code: Relevant Code

Update it like this:

? task.title({
    integrationName,
    workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,
})

4. Add workspaceSettingsLink to the params types of the title here: Relevant Code

Update the params to include:
params: Partial<{
    integrationName: string;
    workspaceSettingsLink: string;
}>

Note: For the title section, we need to wait for the merge of the PR #54165

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[mananjadhav]

@Shahidullah-Muffakir's proposal is good but as mentioned we'll need to put it on hold for the Title markdown support PR.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Shahidullah-Muffakir]

Considering that the pending PR #54165 for title markdown support might take longer to get merged, we can move forward by updating the task description first. This way, users will still have a way to navigate to the workspace settings through the description link, even if the title link isn't available yet.

[mananjadhav]

Will let @jasperhuangg and @jamesdeanexpensify take the call on this one.

[jasperhuangg]

@Shahidullah-Muffakir Yeah I like the idea of updating the two in separate PRs for this issue. Let's get the description out first because this is a pretty critical onboarding flow that we should have right.

[Shahidullah-Muffakir]

@mananjadhav PR is ready for your review.

[mananjadhav]

@jasperhuangg The first PR is ready for you.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add workspace setting link to the Create a workspace task desc #55190

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

@mananjadhav @laurenreidexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]