[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-05] We aren't showing broken connection error on the feed when the connection is broken

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. User added the company card and break to revoke authorization for added card feed

Expected Result:

Broken connection error on the card feed page

Actual Result:

No error message displayed in feed page. Only thing that indicates it is not working properly is, no cards left to assign message displayed (when there is one left)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[allgandalf]

please assign me here, callstack will implement this one most probably

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates:

• I've got the necessary information for code changes during slack discussion. The app will check the lastScrapeResult of the assigned card to define the broken connection status of the feed.
• Waiting on the BE PR which put lastScrapeResult inside cards to be progressed.

[VickyStash]

Updates:
I plan to work on this one tomorrow.

[VickyStash]

Updates:

• I've applied the necessary changes to show a broken connection indication based on lastScrapeResult card field. I've opened a Draft PR with it.

TODOs:

• Implement TODO related to broken connection resolution - navigate the user to the bank account page to enter credentials.
• Fix eslint errors
• Test the updates and prepare the PR for the review.

[VickyStash]

Updates:
I've implemented all of the TODOs mentioned above and opened the PR for review!

[VickyStash]

I've prepared a follow-up PR, which

• Moves flatAllCardsList and checkIfFeedConnectionIsBroken functions to the CardUtils file
• Adds unit tests

cc @mountiny @getusha

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix broken feed connection error display on the Company Cards page #55286

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

@getusha @alexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Follow-up: add unit tests for broken feed connection utility functions #55866

If no regressions arise, payment will be issued on 2025-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

@getusha @alexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• Reviewer: @getusha owed $250 via NewDot

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@alexpensify, @VickyStash, @mountiny, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Contributor: @VickyStash agency-contributor and not due payment
Contributor+: @getusha owed $250 via NewDot

Please submit a request in Chat. Thanks!