Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$750] [HOLD on Mobile-Expensify/pull/13404] Android - Login - Unable to log in using Magic Link received via Email #55447

Closed
1 of 8 tasks
lanitochka17 opened this issue Jan 18, 2025 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 18, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+191@gmail.com
Issue reported by: Applause - Internal Team
Component: Other

Action Performed:

  1. Open the Expensify app
  2. Tap on "Continue with Email"
  3. Complete with any valid Email
  4. Wait for an Email with a Magic Code and Magic Link to arrive
  5. Open the Email and tap on the Magic Link

Expected Result:

User should be automatically logged in after tapping on the Magic Link in the received Email

Actual Result:

A "Trying to authenticate your browser..." message is displayed when trying to log in via Magic Link and the user is given another code to use in order to log in

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6717317_1737178040619.ML.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882796527570338267
  • Upwork Job ID: 1882796527570338267
  • Last Price Increase: 2025-02-06
Issue OwnerCurrent Issue Owner: @c3024
@lanitochka17 lanitochka17 added DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Jan 18, 2025
Copy link

melvin-bot bot commented Jan 18, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 18, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

Production:

screen-20250118-083949.mp4

@Beamanator
Copy link
Contributor

Hmmm i have android hybridapp v9.0.87-0 and I see the magic link working for me!

@Beamanator
Copy link
Contributor

Asked in a few slack channels to see if anyone else can reproduce

@Beamanator
Copy link
Contributor

Seems this is reproducible, so still a blocker :'(

@Beamanator
Copy link
Contributor

Confirmed in this long slack thread - https://expensify.slack.com/archives/C01GTK53T8Q/p1737364468159939 - that this is reproducible on prod app, so this is NAB

@melvin-bot melvin-bot bot added the Overdue label Jan 20, 2025
@Beamanator
Copy link
Contributor

Also the way that we consistently reproduced is with a 2FA-enabled account

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Overdue DeployBlocker Indicates it should block deploying the API labels Jan 20, 2025
@Beamanator Beamanator added Bug Something is broken. Auto assigns a BugZero manager. and removed Overdue labels Jan 20, 2025
Copy link

melvin-bot bot commented Jan 20, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@NikkiWines
Copy link
Contributor

TYSM for the investigation into this while I was out @Beamanator 🙌

@twisterdotcom
Copy link
Contributor

How can I help here? Or will it just be paying out a C+?

@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2025
@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Jan 24, 2025
@melvin-bot melvin-bot bot changed the title Android - Login - Unable to log in using Magic Link received via Email [$250] Android - Login - Unable to log in using Magic Link received via Email Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021882796527570338267

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

Copy link

melvin-bot bot commented Jan 28, 2025

@twisterdotcom, @NikkiWines, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 28, 2025
@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jan 28, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
@twisterdotcom twisterdotcom changed the title [$250] Android - Login - Unable to log in using Magic Link received via Email [$500] Android - Login - Unable to log in using Magic Link received via Email Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

Upwork job price has been updated to $500

Copy link

melvin-bot bot commented Feb 1, 2025

@twisterdotcom @NikkiWines @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@c3024
Copy link
Contributor

c3024 commented Feb 3, 2025

No proposals yet!

@melvin-bot melvin-bot bot removed the Overdue label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

@twisterdotcom, @NikkiWines, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@twisterdotcom twisterdotcom changed the title [$500] Android - Login - Unable to log in using Magic Link received via Email [$750] Android - Login - Unable to log in using Magic Link received via Email Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Upwork job price has been updated to $750

@twisterdotcom
Copy link
Contributor

Updated the price, I think this is worth it.

@war-in
Copy link
Contributor

war-in commented Feb 6, 2025

Hi 👋 I noticed the message in the open-source channel. We're currently working on bringing deeplinks feature back to HybridApp here.

The issue mentioned in the description should work with the PR but let me check it

@twisterdotcom twisterdotcom changed the title [$750] Android - Login - Unable to log in using Magic Link received via Email [$750] [HOLD on Mobile-Expensify/pull/13404] Android - Login - Unable to log in using Magic Link received via Email Feb 6, 2025
@war-in
Copy link
Contributor

war-in commented Feb 6, 2025

I can confirm that the user is automatically logged in after tapping on the Magic Link in the received Email when using the mentioned PR

Screen.Recording.Feb.6.2025.from.Marcin.Warchol.mp4

@twisterdotcom
Copy link
Contributor

Okay, let's close this one for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants