Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - System message for deleted expense omits the decimals when the decimals are 0 #55833

Open
8 tasks done
mitarachim opened this issue Jan 28, 2025 · 19 comments
Open
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Jan 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two expenses whose amount is a whole number without decimals.
  4. Go to expense report.
  5. Right click on any expense preview.
  6. Click Delete expense.
  7. Delete the expense.

Expected Result:

The system message for the deleted expense will display the amount including the 0 decimals - RM123.00.

(When editing expense amount, the system message also displays the amount even when the decimals are 0).

Actual Result:

The system message for the deleted expense omits the decimals when the decimals are 0.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6725789_1738041256551.20250128_130746.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 28, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 28, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@zanyrenney
Copy link
Contributor

Hey @youssef-lr please could you take a look at this one when you get a moment, please?

@zanyrenney
Copy link
Contributor

bump @youssef-lr any update here?

@youssef-lr youssef-lr added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 28, 2025
@youssef-lr
Copy link
Contributor

Demoting as it's pretty minor, I'll look into this today. cc @nkdengineer as well

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
@zanyrenney
Copy link
Contributor

any update on the progress with this @youssef-lr, please? Thank you!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 31, 2025
@zanyrenney
Copy link
Contributor

Bump @youssef-lr

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@zanyrenney
Copy link
Contributor

Bump @youssef-lr

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

@youssef-lr @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 11, 2025

@youssef-lr, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Feb 13, 2025

@youssef-lr, @zanyrenney Still overdue 6 days?! Let's take care of this!

@zanyrenney
Copy link
Contributor

Yousef is OOO, I messaged him in ND. Waiting on him to return.

@zanyrenney
Copy link
Contributor

adding to expense.

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
@zanyrenney
Copy link
Contributor

Hey @youssef-lr I think you're back from OOO now, any update on this one please?

@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2025
@zanyrenney
Copy link
Contributor

https://expensify.slack.com/archives/C06ML6X0W9L/p1740152067054769

taking this to the channel.

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2025
@youssef-lr
Copy link
Contributor

I'm working on the backend PR for this, should be ready on Monday

@melvin-bot melvin-bot bot added the Overdue label Feb 24, 2025
@zanyrenney
Copy link
Contributor

awesome thank you @youssef-lr ! How are we getting on? Still thinking this will be done by today EOD?

@melvin-bot melvin-bot bot removed the Overdue label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: No status
Development

No branches or pull requests

3 participants