[$250] Loading indicator on the Inbox page has thinner line than on the Reports page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to Account settings > Troubleshoot.
4. Click Clear cache and restart > Reset and refresh.
5. Compare the thickness of loading indicator in Inbox and Reports.

Expected Result:

The loading indicator in Inbox should have the same thickness as the one on the Reports page.

Actual Result:

The loading indicator in Inbox is thinner than on the Reports page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725831_1738045224757.20250128_141644.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884250021913137171
• Upwork Job ID: 1884250021913137171
• Last Price Increase: 2025-01-28

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[hungvu193]

Offending PR:
#52272

It came from this line:

App/src/styles/index.ts

Line 5365 in e411125

marginBottom: -1,

[trjExpensify]

@Expensify/design for eyes on what we want. I don't think it's a blocker really though, but should be a quick fix!

[Gonals]

Yep, I don't think we should block on this, so removing the label!

[dannymcclain]

Agree we don't need to block on this, but let's fix it! The reports version is actually the correct thickness. The inbox one looks too thin.

[trjExpensify]

Great, I've updated the OP and title to make it clear which one is wrong here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884250021913137171

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[rdipippo]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-28 15:52:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The loading indicator on the inbox page does not match the one on the index page.

What is the root cause of that problem?

This line:

App/src/styles/index.ts

Line 5365 in e411125

marginBottom: -1,

The negative margin on the bottom is not necessary and is the cause of the incorrect thickness. It is shifting the content one pixel, making that portion unviewable.

What changes do you think we should make in order to solve the problem?

Remove the offending line.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @rdipippo Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[hungvu193]

@rdipippo Please provide a correct RCA. Thanks

[shawnborton]

Huh, I agree with where we landed but what's weird is that on the current staging website, the loading bar looks totally correct to me.

[Themoonalsofall]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Loading indicator on the Inbox page has thinner line than on the Reports page

What is the root cause of that problem?

The above problem only occurs when we show the loading bar together with OptionsListSkeletonView

App/src/pages/home/sidebar/SidebarLinks.tsx

Lines 96 to 100 in 18b2577

	{!!isLoading && optionListItems?.length === 0 && (
	<View style={[StyleSheet.absoluteFillObject, styles.appBG]}>
	<OptionsListSkeletonView shouldAnimate />
	</View>
	)}

We are using StyleSheet.absoluteFillObject which is style position: "absolute", inset: 0px

This causes the bottom margin to not work properly.

To verify, you can delete StyleSheet.absoluteFillObject and add position absolute and top 1px, the loading bar will still show correctly.

What changes do you think we should make in order to solve the problem?

Remove margin-bottom: -1px in this style

App/src/styles/index.ts

Lines 5360 to 5366 in e411125

	progressBarWrapper: {
	height: 2,
	width: '100%',
	backgroundColor: theme.transparent,
	overflow: 'hidden',
	marginBottom: -1,
	},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

We can remove style StyleSheet.absoluteFillObject and add position absolute with top 1px

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Themoonalsofall]

@shawnborton To reproduce the above bug, you need to go to Troubleshoot -> Clear cache and restart to show skeleton loading.

[shawnborton]

Got it, yeah I can reproduce if I do that. Weird that it works fine in other cases though.

[srikarparsi]

@nkdengineer and @getusha, do you think you can take a look at this one as a follow up from #46611? Also, I can take this over @Gonals

[dubielzyk-expensify]

I also got the thinner bar all of a sudden 🤔

[joekaufmanexpensify]

Yeah, if @nkdengineer and @getusha are available, that would be great since it looks like it was introduced in a PR you just worked on

[getusha]

We noticed this in the PR: #52272 (comment). Having a look

[getusha]

This only happens when the skeleton loader appears. we could just add a marginTop: 1, here:

App/src/pages/home/sidebar/SidebarLinks.tsx

Line 97 in 4459f86

<View style={[StyleSheet.absoluteFillObject, styles.appBG]}>

But would like a confirmation from @nkdengineer why we would need the marginBottom: -1

[nkdengineer]

@getusha The reason is here.

[melvin-bot]

@hungvu193, @srikarparsi, @joekaufmanexpensify Eep! 4 days overdue now. Issues have feelings too...

[getusha]

@nkdengineer could you raise a PR to fix this?

[nkdengineer]

Will give an update tomorrow.

[joekaufmanexpensify]

TY!

[nkdengineer]

@getusha Since we already have a space 12px when the report is loaded in LHN, we should have the same space for skeleton view wrapper.

[nkdengineer]

@getusha The PR is ready for review.

[joekaufmanexpensify]

PR in review.

[joekaufmanexpensify]

Same