[Due for payment 2025-02-10] [HOLD for payment 2025-02-07] All - Approvers Flow - Empty report created in OD is displayed in ND with the Submit button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5531243
Email or phone of affected tester (no customers): fischer9966+013025aemp@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.2 - Safari, Chrome, Desktop. iPhone 15 Pro / 18.2.1. Google Pixel 5 / Android 14
App Component: Chat Report View

Action Performed:

1. Create Admin account with Gmail
2. Create Collect workspace, set Workflows to enabled
3. Enable Approvals in Workflows and set Admin account as Approver
4. Enable Workflows > Delay submissions and set it to Manually
5. Invite employee to workspace
6. Login as employee in OD
7. Go to Reports and create empty report
8. Login as employee in ND
9. Go to workspace chat and check the display of the report created in OD

Expected Result:

Empty report created in OD does not have a Submit button in ND

Actual Result:

Empty report created in OD is displayed in ND with the Submit button.
Non-reimbursable expense added to report in OD has Submit button in ND.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6728291_1738223778547.56018-Empty-Report-OD-has-Submit-button-ND.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[grgia]

#55610

[grgia]

Posted to the slack thread

[grgia]

Being worked on in #56094

[grgia]

Non-reimbursable expense added to report in OD has Submit button in ND.

For this, i think there's an existing production BE issue where manual expenses aren't properly set

[grgia]

Did not intend to remove the label, I dont want to retrigger it though

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed submit button in empty expense report #56094

If no regressions arise, payment will be issued on 2025-02-07. 🎊

[melvin-bot]

@grgia @abekkala @grgia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed submit button in empty expense report #56094

If no regressions arise, payment will be issued on 2025-02-10. 🎊

[melvin-bot]

@grgia @abekkala @grgia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@abekkala, @grgia Huh... This is 4 days overdue. Who can take care of this?

[abekkala]

@ishpaul777
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it.

[abekkala]

@ishpaul777 can you please complete the checklist?

[ishpaul777]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/55610/files#r1958214045

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: not critical, a edge case that was never considered

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:https://github.com/Expensify/Expensify/issues/471754

Regression Test Proposal

Precondition: N/A

Test:

1. Create Admin account with Gmail
2. Create Collect workspace, set Workflows to enabled
3. Enable Approvals in Workflows and set Admin account as Approver
4. Enable Workflows > Delay submissions and set it to Manually
5. Invite employee to workspace
6. Login as employee in OD
7. Go to Reports and create empty report
8. Login as employee in ND
9. Go to workspace chat and check the display of the report created in OD

Expected Result:
Empty report created in OD does not have a Submit button in ND

Do we agree 👍 or 👎

[shubham1206agra]

@abekkala No payment required here.

[melvin-bot]

@abekkala, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!