Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concierge - Message after tracking expense ends with "your workspace set up" #56325

Closed
2 of 8 tasks
IuliiaHerets opened this issue Feb 4, 2025 · 10 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #56141
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Apple iPhone 13 / Safari
App Component: Other

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new Gmail account
  3. Choose the "Track and budget expense" onboarding option
  4. navigate to the self DM
  5. Navigate to Composer + button - Create expense - Manual
  6. Create an expense with any amount
  7. Click on "Categorize it"
  8. Click on "Upgrade"
  9. Click on "Got it, thanks"
  10. Finish creating the expense with any category and merchant
  11. Click on Concierge" in the LHN

Expected Result:

The message should be "Here are some important tasks to help get your team’s expenses under control."

Actual Result:

Message after tracking expense is "Here are some important tasks to help get your workspace set up.". The message is correct if you choose any other onboarding option than "Manage my team's expense".

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6732990_1738664383675.bandicam_2025-02-04_11-09-38-574.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Different behavior on prod

bandicam.2025-02-04.13-40-06-375.mp4

@ishpaul777
Copy link
Contributor

ishpaul777 commented Feb 4, 2025

@mjasikowski
Copy link
Contributor

It seems that @ishpaul777 is right, but let's confirm with @francoisl. In the meantime, since it's just a copy problem, I'm demoting this.

@mjasikowski mjasikowski added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 4, 2025
@francoisl
Copy link
Contributor

francoisl commented Feb 5, 2025

The message is fine, but the onboarding tasks should have been created in admins room instead of the Concierge chat. Were you using an alias account like something+xyz@example.com?
Anyway, no need to block on the message.

@greg-schroeder greg-schroeder moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Feb 5, 2025
@mjasikowski
Copy link
Contributor

@ishpaul777 can you look into this please, even if just to confirm everything is in order?

@ishpaul777
Copy link
Contributor

The message is fine, but the onboarding tasks should have been created in admins room instead of the Concierge chat. Were you using an alias account like something+xyz@example.com?

I believe yes that's the only case when we post message in concierge

@ishpaul777 can you look into this please, even if just to confirm everything is in order?

yes everything seems in order and expected this is good to close

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

5 participants