Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-18] [Due for payment 2025-02-13] Workspace - Setup specialist appears in member list and throws error when invited #56351

Closed
6 of 8 tasks
vincdargento opened this issue Feb 4, 2025 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2

Comments

@vincdargento
Copy link

vincdargento commented Feb 4, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ssdjmosijmosdjos@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new Gmail account.
  3. Select "Something else" during onboarding and complete the flow.
  4. Create a new workspace.
  5. Go to Workspace settings > Members.
  6. Click Invite member.
  7. Select Setup specialist and invite the person.

Expected Result:

  • Setup specialist should have fallback avatar.
  • Setup specialist should be invited without issue or should be hidden from the invite list if they are not meant to be invited.

Actual Result:

  • Setup specialist has fallback avatar.
  • App throws error when trying to invite Setup specialist.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC
@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 4, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@MarioExpensify
Copy link
Contributor

Hey @vincdargento, thanks for opening this issue. I'm gonna investigate if this is BE related or we can get external help and circle back here. @OfstadC if you have any insights please let us know.

@MarioExpensify
Copy link
Contributor

Image

This is the output of the AddMembersToWorkspace call.

@MarioExpensify
Copy link
Contributor

The issue looks to be related with this PR: #55302

This is the commit that first introduced the issue: bb02e14

@ishpaul777 can you help track and fix this?

@MarioExpensify
Copy link
Contributor

oookay! Looking at the deploy checklist looks like we got this fixed. Thank you for your help @ishpaul777. Closing this.

@MarioExpensify
Copy link
Contributor

Whoops, should not have closed this. Waiting for QA retest. But looks good in Staging already!

@izarutskaya
Copy link

We don't see Setup specialist

Recording.2840.mp4
Recording.2977.mp4

@MarioExpensify
Copy link
Contributor

Correct. Setup Specialist should not be displayed in invite list (just like in Prod).

@MarioExpensify
Copy link
Contributor

Closing now that QA retested this!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot changed the title Workspace - Setup specialist appears in member list and throws error when invited [Due for payment 2025-02-13] Workspace - Setup specialist appears in member list and throws error when invited Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

Copy link

melvin-bot bot commented Feb 6, 2025

@MarioExpensify @OfstadC @MarioExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 11, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-13] Workspace - Setup specialist appears in member list and throws error when invited [Due for payment 2025-02-18] [Due for payment 2025-02-13] Workspace - Setup specialist appears in member list and throws error when invited Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-18. 🎊

Copy link

melvin-bot bot commented Feb 11, 2025

@MarioExpensify @OfstadC @MarioExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants